Hadoop Common
  1. Hadoop Common
  2. HADOOP-7122

Timed out shell commands leak Timer threads

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0
    • Component/s: util
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      When a shell command times out, the TimerThread used to cause the timeout is leaked.

      1. hadoop-7122.txt
        3 kB
        Todd Lipcon
      2. hadoop-7122.txt
        3 kB
        Todd Lipcon

        Activity

        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12469606/hadoop-7122.txt
        against trunk revision 1063613.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/203//testReport/
        Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/203//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/203//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12469606/hadoop-7122.txt against trunk revision 1063613. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/203//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/203//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/203//console This message is automatically generated.
        Hide
        Eli Collins added a comment -

        Good catch.

        +1

        Nits:

        • The System.err.println on line 111 in the test seems gratuitous
        • On line 112 perhaps s/contains/equals/ since you're explicitly looking for the Timer objects
        Show
        Eli Collins added a comment - Good catch. +1 Nits: The System.err.println on line 111 in the test seems gratuitous On line 112 perhaps s/contains/equals/ since you're explicitly looking for the Timer objects
        Hide
        Todd Lipcon added a comment -

        Unfortuntaely the Timer threads have java.util.TimerThread on the stack, but this class is a private "implementation detail" class. To work across different JVMs I elected to just look for the word "Timer" - make sense?

        Will fix the println

        Show
        Todd Lipcon added a comment - Unfortuntaely the Timer threads have java.util.TimerThread on the stack, but this class is a private "implementation detail" class. To work across different JVMs I elected to just look for the word "Timer" - make sense? Will fix the println
        Hide
        Eli Collins added a comment -

        Makes sense.

        +1

        Show
        Eli Collins added a comment - Makes sense. +1
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12469608/hadoop-7122.txt
        against trunk revision 1063613.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/204//testReport/
        Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/204//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/204//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12469608/hadoop-7122.txt against trunk revision 1063613. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/204//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/204//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/204//console This message is automatically generated.
        Hide
        Todd Lipcon added a comment -

        Committed to trunk and branch, thanks for the quick review.

        Show
        Todd Lipcon added a comment - Committed to trunk and branch, thanks for the quick review.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-22-branch #20 (See https://hudson.apache.org/hudson/job/Hadoop-Common-22-branch/20/)
        HADOOP-7122. Fix thread leak when shell commands time out. Contributed by Todd Lipcon

        Show
        Hudson added a comment - Integrated in Hadoop-Common-22-branch #20 (See https://hudson.apache.org/hudson/job/Hadoop-Common-22-branch/20/ ) HADOOP-7122 . Fix thread leak when shell commands time out. Contributed by Todd Lipcon
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #589 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/589/)
        HADOOP-7122. Fix thread leak when shell commands time out. Contributed by Todd Lipcon

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #589 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/589/ ) HADOOP-7122 . Fix thread leak when shell commands time out. Contributed by Todd Lipcon
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #492 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/492/)

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #492 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/492/ )

          People

          • Assignee:
            Todd Lipcon
            Reporter:
            Todd Lipcon
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development