Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In HADOOP-7082 I stupidly introduced a regression whereby Configuration.writeXml will throw an NPE if it is called before any .get() call is made, since the properties member is not initialized. This is causing a failure in TestCapacitySchedulerWithJobTracker on my box, but doesn't appear to trigger any failures in the non-contrib tests since .get() is usually called first.

      This JIRA is to fix the bug and add a unit test for writeXml in common (apparently it never had a unit test)

      1. hadoop-7118.txt
        2 kB
        Todd Lipcon
      2. hadoop-7118.txt
        2 kB
        Todd Lipcon

        Activity

        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12469351/hadoop-7118.txt
        against trunk revision 1063090.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/198//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12469351/hadoop-7118.txt against trunk revision 1063090. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/198//console This message is automatically generated.
        Hide
        Todd Lipcon added a comment -

        Woops, patch was against yesterday's common tree, didn't apply. Take two.

        Show
        Todd Lipcon added a comment - Woops, patch was against yesterday's common tree, didn't apply. Take two.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12469356/hadoop-7118.txt
        against trunk revision 1063090.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/199//testReport/
        Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/199//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/199//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12469356/hadoop-7118.txt against trunk revision 1063090. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/199//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/199//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/199//console This message is automatically generated.
        Hide
        Konstantin Boudnik added a comment -

        +1 LGTM. I would also convert the test to JUnitv4 but one can't have everything, I guess

        Show
        Konstantin Boudnik added a comment - +1 LGTM. I would also convert the test to JUnitv4 but one can't have everything, I guess
        Hide
        Todd Lipcon added a comment -

        Committed, thanks for review Cos.

        Show
        Todd Lipcon added a comment - Committed, thanks for review Cos.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-22-branch #19 (See https://hudson.apache.org/hudson/job/Hadoop-Common-22-branch/19/)
        HADOOP-7118. Fix NPE in Configuration.writeXml. Contributed by Todd Lipcon

        Show
        Hudson added a comment - Integrated in Hadoop-Common-22-branch #19 (See https://hudson.apache.org/hudson/job/Hadoop-Common-22-branch/19/ ) HADOOP-7118 . Fix NPE in Configuration.writeXml. Contributed by Todd Lipcon
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #587 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/587/)
        HADOOP-7118. Fix NPE in Configuration.writeXml. Contributed by Todd Lipcon

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #587 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/587/ ) HADOOP-7118 . Fix NPE in Configuration.writeXml. Contributed by Todd Lipcon
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #492 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/492/)

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #492 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/492/ )

          People

          • Assignee:
            Todd Lipcon
            Reporter:
            Todd Lipcon
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development