Hadoop Common
  1. Hadoop Common
  2. HADOOP-7094

hadoop.css got lost during project split

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      hadoop.css no longer exists in common or HDFS, so the web UIs look pretty ugly. The HTML still refers to this file, it's just gone.

      1. HADOOP-7094.patch
        4 kB
        Konstantin Boudnik
      2. HADOOP-7094.patch
        3 kB
        Konstantin Boudnik

        Issue Links

          Activity

          Todd Lipcon created issue -
          Hide
          Nigel Daley added a comment -

          This needs to be fixed.

          Show
          Nigel Daley added a comment - This needs to be fixed.
          Nigel Daley made changes -
          Field Original Value New Value
          Priority Critical [ 2 ] Blocker [ 1 ]
          Hide
          Konstantin Boudnik added a comment -

          Patch for the issue

          Show
          Konstantin Boudnik added a comment - Patch for the issue
          Konstantin Boudnik made changes -
          Attachment HADOOP-7094.patch [ 12470897 ]
          Konstantin Boudnik made changes -
          Assignee Konstantin Boudnik [ cos ]
          Konstantin Boudnik made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Todd Lipcon added a comment -

          sure. +1 assuming you've tested that this gets picked up by the NN and JT web UIs on trunk?

          Show
          Todd Lipcon added a comment - sure. +1 assuming you've tested that this gets picked up by the NN and JT web UIs on trunk?
          Hide
          Todd Lipcon added a comment -

          We should also file a JIRA to create an hdfs.css and mapred.css in the individual projects, since some of these CSS rules are specific to one or the other. But for now I think this changes infrequently enough that we can leave as is.

          Show
          Todd Lipcon added a comment - We should also file a JIRA to create an hdfs.css and mapred.css in the individual projects, since some of these CSS rules are specific to one or the other. But for now I think this changes infrequently enough that we can leave as is.
          Hide
          Konstantin Boudnik added a comment -

          Well, technically patch returns the file to the same location where src/java/org/apache/hadoop/util/ServletUtil.java is looking for it. But yes - I will assemble a cluster and make sure that it's there.

          Show
          Konstantin Boudnik added a comment - Well, technically patch returns the file to the same location where src/java/org/apache/hadoop/util/ServletUtil.java is looking for it. But yes - I will assemble a cluster and make sure that it's there.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12470897/HADOOP-7094.patch
          against trunk revision 1069677.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/227//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/227//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/227//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12470897/HADOOP-7094.patch against trunk revision 1069677. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/227//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/227//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/227//console This message is automatically generated.
          Hide
          Konstantin Boudnik added a comment -

          Apparently appropriate build code was lost two (Todd, you knew it damn it
          Now everything is in place and being copied to webapps/static as a part of 'package' target.

          Show
          Konstantin Boudnik added a comment - Apparently appropriate build code was lost two (Todd, you knew it damn it Now everything is in place and being copied to webapps/static as a part of 'package' target.
          Konstantin Boudnik made changes -
          Attachment HADOOP-7094.patch [ 12470927 ]
          Hide
          Konstantin Boudnik added a comment -

          It looks like that the whole hadoop.css jazz has been moved to MR (as a designated top-level) component. HDFS doesn't have any hadoop.css, which is perhaps ok for it requires to have common along at any rate.

          Show
          Konstantin Boudnik added a comment - It looks like that the whole hadoop.css jazz has been moved to MR (as a designated top-level) component. HDFS doesn't have any hadoop.css, which is perhaps ok for it requires to have common along at any rate.
          Konstantin Boudnik made changes -
          Status Patch Available [ 10002 ] In Progress [ 3 ]
          Konstantin Boudnik made changes -
          Hadoop Flags [Reviewed]
          Component/s build [ 12311543 ]
          Konstantin Boudnik made changes -
          Status In Progress [ 3 ] Open [ 1 ]
          Hide
          Konstantin Boudnik added a comment -

          resubmitting

          Show
          Konstantin Boudnik added a comment - resubmitting
          Konstantin Boudnik made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12470927/HADOOP-7094.patch
          against trunk revision 1070021.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/230//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/230//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/230//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12470927/HADOOP-7094.patch against trunk revision 1070021. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/230//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/230//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/230//console This message is automatically generated.
          Hide
          Konstantin Boudnik added a comment -

          I have committed this to the trunk and branch 0.22

          Show
          Konstantin Boudnik added a comment - I have committed this to the trunk and branch 0.22
          Konstantin Boudnik made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #506 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/506/)
          HADOOP-7094. hadoop.css got lost during project split
          Committing missed folder

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #506 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/506/ ) HADOOP-7094 . hadoop.css got lost during project split Committing missed folder
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-22-branch #27 (See https://hudson.apache.org/hudson/job/Hadoop-Common-22-branch/27/)
          HADOOP-7094. svn merge -c 1071084 from trunk

          Show
          Hudson added a comment - Integrated in Hadoop-Common-22-branch #27 (See https://hudson.apache.org/hudson/job/Hadoop-Common-22-branch/27/ ) HADOOP-7094 . svn merge -c 1071084 from trunk
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #608 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/608/)
          HADOOP-7094. hadoop.css got lost during project split
          Committing missed folder
          HADOOP-7094. hadoop.css got lost during project split. Contributed by Konstantin Boudnik.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #608 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/608/ ) HADOOP-7094 . hadoop.css got lost during project split Committing missed folder HADOOP-7094 . hadoop.css got lost during project split. Contributed by Konstantin Boudnik.
          Eugene Koontz made changes -
          Link This issue relates to HDFS-1013 [ HDFS-1013 ]
          Konstantin Shvachko made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Roman Shaposhnik made changes -
          Link This issue is related to HDFS-3578 [ HDFS-3578 ]

            People

            • Assignee:
              Konstantin Boudnik
              Reporter:
              Todd Lipcon
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development