Hadoop Common
  1. Hadoop Common
  2. HADOOP-7082

Configuration.writeXML should not hold lock while outputting

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0
    • Component/s: conf
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Common side of HDFS-1542

        Issue Links

          Activity

          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12467242/hadoop-7082.txt
          against trunk revision 1052933.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/152//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/152//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/152//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12467242/hadoop-7082.txt against trunk revision 1052933. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/152//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/152//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/152//console This message is automatically generated.
          Hide
          Todd Lipcon added a comment -

          -1 tests included. The patch doesn't appear to include any new or modified tests.

          The test is on the HDFS side (HDFS-1542)

          Show
          Todd Lipcon added a comment - -1 tests included. The patch doesn't appear to include any new or modified tests. The test is on the HDFS side ( HDFS-1542 )
          Hide
          dhruba borthakur added a comment -

          This looks right. Todd, can you pl upload the patch into reviewBoard as well (just makes the review easy)? Thanks a bunch.

          Show
          dhruba borthakur added a comment - This looks right. Todd, can you pl upload the patch into reviewBoard as well (just makes the review easy)? Thanks a bunch.
          Show
          Todd Lipcon added a comment - https://reviews.apache.org/r/207/
          Hide
          dhruba borthakur added a comment -

          +1, code looks good.

          Show
          dhruba borthakur added a comment - +1, code looks good.
          Hide
          Todd Lipcon added a comment -

          Committed to 0.22 branch and trunk

          Show
          Todd Lipcon added a comment - Committed to 0.22 branch and trunk
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #567 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/567/)
          HADOOP-7082. Configuration.writeXML should not hold lock while outputting. Contributed by Todd Lipcon

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #567 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/567/ ) HADOOP-7082 . Configuration.writeXML should not hold lock while outputting. Contributed by Todd Lipcon
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #643 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/643/)

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #643 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/643/ )
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-22-branch #35 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-22-branch/35/)

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-22-branch #35 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-22-branch/35/ )
          Hide
          John George added a comment -

          Can someone pull this patch into MR-279 branch?

          Show
          John George added a comment - Can someone pull this patch into MR-279 branch?
          Hide
          Chris Douglas added a comment -

          Can someone pull this patch into MR-279 branch?

          Done.

          Show
          Chris Douglas added a comment - Can someone pull this patch into MR-279 branch? Done.

            People

            • Assignee:
              Todd Lipcon
              Reporter:
              Todd Lipcon
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development