Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.21.0
    • Fix Version/s: 0.23.0
    • Component/s: native
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Adds __attribute__ ((unused))

      Description

      The file:
      src/native/src/org_apache_hadoop.h

      declares the static function "do_dlsym" in the header as non-inline. Files including the header (e.g. for the THROW macro) receive a "defined but unused" warning during compilation.

      This function should either a) be inlined or b) use GCC "unused" attribute.

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #543 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/543/)
        HADOOP-7059. Remove "unused" warning in native code. Contributed by Noah Watkins

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #543 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/543/ ) HADOOP-7059 . Remove "unused" warning in native code. Contributed by Noah Watkins
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #457 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/457/)
        HADOOP-7059. Remove "unused" warning in native code. Contributed by Noah Watkins

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #457 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/457/ ) HADOOP-7059 . Remove "unused" warning in native code. Contributed by Noah Watkins
        Hide
        Eli Collins added a comment -

        I double checked the native build and committed this. Thanks Noah!

        Show
        Eli Collins added a comment - I double checked the native build and committed this. Thanks Noah!
        Hide
        Eli Collins added a comment -

        +1

        Show
        Eli Collins added a comment - +1
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12465745/HADOOP-7059-1.patch
        against trunk revision 1043117.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/135//testReport/
        Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/135//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/135//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12465745/HADOOP-7059-1.patch against trunk revision 1043117. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/135//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/135//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/135//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12465741/HADOOP-7059-1.patch
        against trunk revision 1043117.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/134//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12465741/HADOOP-7059-1.patch against trunk revision 1043117. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/134//console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org
        against trunk revision 1043117.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/133//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org against trunk revision 1043117. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/133//console This message is automatically generated.

          People

          • Assignee:
            Noah Watkins
            Reporter:
            Noah Watkins
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development