Hadoop Common
  1. Hadoop Common
  2. HADOOP-7034

Add TestPath tests to cover dot, dot dot, and slash normalization

    Details

    • Type: Test Test
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0
    • Component/s: fs
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Add tests for the current path normalization for dot, dot dot, and slash in TestPath (from HDFS-836).

        Activity

        Hide
        Eli Collins added a comment -

        Patch attached. This is pretty trivial, just adds three asserts to TestPath#testNormalize. TestPath passes.

        Show
        Eli Collins added a comment - Patch attached. This is pretty trivial, just adds three asserts to TestPath#testNormalize. TestPath passes.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12459548/hadoop-7034-1.patch
        against trunk revision 1034480.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/102//testReport/
        Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/102//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/102//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12459548/hadoop-7034-1.patch against trunk revision 1034480. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 javadoc. The javadoc tool appears to have generated 1 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/102//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/102//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/102//console This message is automatically generated.
        Hide
        Eli Collins added a comment -

        Not sure what the javadoc warning is about, I see 7 warnings with and w/o my change.

        Show
        Eli Collins added a comment - Not sure what the javadoc warning is about, I see 7 warnings with and w/o my change.
        Hide
        Konstantin Boudnik added a comment -

        +1 patch looks good.

        Show
        Konstantin Boudnik added a comment - +1 patch looks good.
        Hide
        Eli Collins added a comment -

        Thanks Cos. I've committed this.

        Show
        Eli Collins added a comment - Thanks Cos. I've committed this.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #423 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/423/)
        HADOOP-7034. Add TestPath tests to cover dot, dot dot, and slash normalization. Contributed by Eli Collins

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #423 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/423/ ) HADOOP-7034 . Add TestPath tests to cover dot, dot dot, and slash normalization. Contributed by Eli Collins
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #514 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/514/)

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #514 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/514/ )

          People

          • Assignee:
            Eli Collins
            Reporter:
            Eli Collins
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development