Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.20.3
    • Component/s: None
    • Labels:
      None

      Description

      I'd like to move to a newer patch level of Jetty. 6.1.23 (instead of our current 6.1.14) has been suggested. As seen in http://svn.codehaus.org/jetty/jetty/branches/jetty-6.1/VERSION.txt, that represents 18 months of bug fixes.

      1. h-6882-c.patch
        1 kB
        Owen O'Malley
      2. h-6882-h.patch
        0.6 kB
        Owen O'Malley
      3. h-6882-mr.patch
        0.5 kB
        Owen O'Malley
      4. h-6882-20.patch
        0.4 kB
        Owen O'Malley

        Issue Links

          Activity

          Hide
          Todd Lipcon added a comment -

          Agreed. We're also susceptible to this deadlock in jetty <6.1.26. Though I haven't seen it in practice, it shows up on rare occasion in jcarder analysis:
          http://jira.codehaus.org/browse/JETTY-1264

          Show
          Todd Lipcon added a comment - Agreed. We're also susceptible to this deadlock in jetty <6.1.26. Though I haven't seen it in practice, it shows up on rare occasion in jcarder analysis: http://jira.codehaus.org/browse/JETTY-1264
          Hide
          Owen O'Malley added a comment -

          Here's the patch for 0.20. This is required after HADOOP-6760.

          Show
          Owen O'Malley added a comment - Here's the patch for 0.20. This is required after HADOOP-6760 .
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12468698/h-6882-20.patch
          against trunk revision 1060632.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 patch. The patch command could not apply the patch.

          Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/187//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12468698/h-6882-20.patch against trunk revision 1060632. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/187//console This message is automatically generated.
          Hide
          Owen O'Malley added a comment -

          Here are the changes to fix trunk. It just deletes the unused properties out of hdfs and mapreduce and updates common to the new version.

          Show
          Owen O'Malley added a comment - Here are the changes to fix trunk. It just deletes the unused properties out of hdfs and mapreduce and updates common to the new version.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12468825/h-6882-c.patch
          against trunk revision 1060632.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/188//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/188//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/188//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12468825/h-6882-c.patch against trunk revision 1060632. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/188//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/188//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/188//console This message is automatically generated.
          Hide
          Arun C Murthy added a comment -

          +1

          Show
          Arun C Murthy added a comment - +1
          Hide
          Steve Loughran added a comment -

          +1, been using the .26 release in other code and not found any problems with it

          Show
          Steve Loughran added a comment - +1, been using the .26 release in other code and not found any problems with it
          Hide
          Todd Lipcon added a comment -

          Some MR contribs list the jetty jsp-api stuff in their ivy.xml. This needs to be removed by the patch too, I think?

          $ find src/contrib -name ivy.xml | xargs grep -l jsp-api
          src/contrib/mumak/ivy.xml
          src/contrib/streaming/ivy.xml
          src/contrib/raid/ivy.xml
          src/contrib/gridmix/ivy.xml
          src/contrib/fairscheduler/ivy.xml
          src/contrib/capacity-scheduler/ivy.xml

          Show
          Todd Lipcon added a comment - Some MR contribs list the jetty jsp-api stuff in their ivy.xml. This needs to be removed by the patch too, I think? $ find src/contrib -name ivy.xml | xargs grep -l jsp-api src/contrib/mumak/ivy.xml src/contrib/streaming/ivy.xml src/contrib/raid/ivy.xml src/contrib/gridmix/ivy.xml src/contrib/fairscheduler/ivy.xml src/contrib/capacity-scheduler/ivy.xml
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12468825/h-6882-c.patch
          against trunk revision 1071364.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/267//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/267//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/267//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12468825/h-6882-c.patch against trunk revision 1071364. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/267//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/267//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/267//console This message is automatically generated.
          Hide
          Matt Foley added a comment -

          Was the intended fix version 0.23.0 rather than 0.20.3?

          Show
          Matt Foley added a comment - Was the intended fix version 0.23.0 rather than 0.20.3?
          Hide
          Eli Collins added a comment -

          Removing the 0.23 fix version, we've already got an updated jetty (6.1.26) there.

          Show
          Eli Collins added a comment - Removing the 0.23 fix version, we've already got an updated jetty (6.1.26) there.
          Hide
          Matt Foley added a comment -

          This patch went into 0.20.203, and is therefore already in 1.0 and 1.1.
          I'm going to close this unless someone sees a problem with that.

          Show
          Matt Foley added a comment - This patch went into 0.20.203, and is therefore already in 1.0 and 1.1. I'm going to close this unless someone sees a problem with that.

            People

            • Assignee:
              Owen O'Malley
              Reporter:
              Owen O'Malley
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development