What do you mean by "username lookup" here?
+ this.username = conf.getInitParameter(USERNAME_KEY);
+ this.user = new User(username);
I agree it isn't huge, which is why I left it in, but it also isn't adding any value.
The same could be said for every other default throughout all of common, HDFS, and MR, no?
No, actually. We do it in a lot of places, but it leads to lots of confusion. Furthermore, this isn't a framework default, but a plugin default. I don't think it is appropriate to put into the default configuration file.
Apparently most of our very-confused customers who've filed tickets about this don't agree.
The issue isn't the default value of "dr.who". Having a magic value of "webuser" will have exactly the same problem with trying to figure out where it is coming from. Furthermore, if they actually have a real webuser account, it could create problems. I guess we could use "default.web.user" or something.