Hadoop Common
  1. Hadoop Common
  2. HADOOP-6826

Revert FileSystem create method that takes CreateFlags

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: fs
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      As discussed in HDFS-609 and HADOOP-5438 we should back out the FileSystem create() method that takes a set of CreateFlag objects, until the interface has been agreed upon and fully tested.

        Issue Links

          Activity

          Hide
          Tom White added a comment -

          Here's a patch that removes the public create method. It is not a straight revert of HADOOP-5438 since in the intervening time since this was committed the codebase has been split into three projects, and FileContext has been introduced which uses some of the same underlying code.

          The HDFS part of this patch is in HDFS-609.

          Show
          Tom White added a comment - Here's a patch that removes the public create method. It is not a straight revert of HADOOP-5438 since in the intervening time since this was committed the codebase has been split into three projects, and FileContext has been introduced which uses some of the same underlying code. The HDFS part of this patch is in HDFS-609 .
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12447173/HADOOP-6826.patch
          against trunk revision 954647.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/585/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/585/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/585/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/585/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12447173/HADOOP-6826.patch against trunk revision 954647. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javadoc. The javadoc tool appears to have generated 1 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/585/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/585/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/585/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/585/console This message is automatically generated.
          Hide
          Tom White added a comment -

          There are no new tests since this patch removes code. The javadoc warning is an unrelated warning due to sun.security.krb5.* imports (from HADOOP-6526 and HADOOP-6603?) - is anyone looking at this?

          Show
          Tom White added a comment - There are no new tests since this patch removes code. The javadoc warning is an unrelated warning due to sun.security.krb5.* imports (from HADOOP-6526 and HADOOP-6603 ?) - is anyone looking at this?
          Hide
          dhruba borthakur added a comment -

          This revert-patch looks good to me, +1

          Show
          dhruba borthakur added a comment - This revert-patch looks good to me, +1
          Hide
          Tom White added a comment -

          I've committed this.

          Show
          Tom White added a comment - I've committed this.
          Hide
          Ravi Gummadi added a comment -

          This broke compilation of mapreduce trunk.

          Show
          Ravi Gummadi added a comment - This broke compilation of mapreduce trunk.
          Hide
          Ravi Gummadi added a comment -

          Raised MAPREDUCE-1885 in mapreduce project to fix the compilation issue because of this FileSystem api change.

          Show
          Ravi Gummadi added a comment - Raised MAPREDUCE-1885 in mapreduce project to fix the compilation issue because of this FileSystem api change.
          Hide
          Amar Kamat added a comment -

          Tom/Dhruba,
          I think this commit should be reverted. FileSystem.create() is a public api and hence cannot be removed like this. Ideally it should be deprecated. Do you agree?

          Show
          Amar Kamat added a comment - Tom/Dhruba, I think this commit should be reverted. FileSystem.create() is a public api and hence cannot be removed like this. Ideally it should be deprecated. Do you agree?
          Hide
          dhruba borthakur added a comment -

          hi amar, this API never made it to any "release" of Hadoop. Better to remove it now than to ship a release with a bad API.

          Show
          dhruba borthakur added a comment - hi amar, this API never made it to any "release" of Hadoop. Better to remove it now than to ship a release with a bad API.
          Hide
          Tom White added a comment -

          Ravi, I missed that this affected MapReduce: sorry about that! Thanks for opening an issue, and creating a patch to fix MapReduce trunk.

          Amar, This reverts an unreleased API, so we don't need to deprecate it. In fact, the API was broken in some cases (HDFS-609) so we shouldn't release it.

          Show
          Tom White added a comment - Ravi, I missed that this affected MapReduce: sorry about that! Thanks for opening an issue, and creating a patch to fix MapReduce trunk. Amar, This reverts an unreleased API, so we don't need to deprecate it. In fact, the API was broken in some cases ( HDFS-609 ) so we shouldn't release it.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #374 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/374/)
          HADOOP-6826. Revert FileSystem create method that takes CreateFlags.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #374 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/374/ ) HADOOP-6826 . Revert FileSystem create method that takes CreateFlags.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #523 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/523/)

          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #523 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/523/ )

            People

            • Assignee:
              Tom White
              Reporter:
              Tom White
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development