Hadoop Common
  1. Hadoop Common
  2. HADOOP-6815

refreshSuperUserGroupsConfiguration should use server side configuration for the refresh

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.22.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    1. HADOOP-6815-5.patch
      5 kB
      Boris Shkolnik
    2. HADOOP-6815-YH20-1.patch
      22 kB
      Boris Shkolnik
    3. HADOOP-6815-3.patch
      5 kB
      Boris Shkolnik
    4. HADOOP-6815-2.patch
      4 kB
      Boris Shkolnik
    5. HADOOP-6815-1.patch
      4 kB
      Boris Shkolnik
    6. HADOOP-6815.patch
      4 kB
      Boris Shkolnik

      Issue Links

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Patch Available Patch Available Open Open
        12d 18m 2 Boris Shkolnik 22/Jun/10 19:55
        Open Open Patch Available Patch Available
        21h 4m 3 Boris Shkolnik 22/Jun/10 19:55
        Patch Available Patch Available Resolved Resolved
        4h 11m 1 Boris Shkolnik 23/Jun/10 00:07
        Resolved Resolved Closed Closed
        537d 7h 11m 1 Konstantin Shvachko 12/Dec/11 06:19
        Konstantin Shvachko made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Konstantin Shvachko made changes -
        Fix Version/s 0.22.0 [ 12314296 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #375 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/375/)
        HADOOP-6815. refreshSuperUserGroupsConfiguration should use server side configuration for the refresh

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #375 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/375/ ) HADOOP-6815 . refreshSuperUserGroupsConfiguration should use server side configuration for the refresh
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #317 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/317/)
        HDFS-1192. refreshSuperUserGroupsConfiguration should use server side configuration for the refresh (for HADOOP-6815)

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #317 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/317/ ) HDFS-1192 . refreshSuperUserGroupsConfiguration should use server side configuration for the refresh (for HADOOP-6815 )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #314 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/314/)
        HADOOP-6815. refreshSuperUserGroupsConfiguration should use server side configuration for the refresh

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #314 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/314/ ) HADOOP-6815 . refreshSuperUserGroupsConfiguration should use server side configuration for the refresh
        Boris Shkolnik made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Resolution Fixed [ 1 ]
        Hide
        Boris Shkolnik added a comment -

        javadoc warning is related to "sun.security.krb5.PrincipalName is Sun proprietary API and may be removed in a future release" issue introduces elsewhere.

        committed to trunk.

        Show
        Boris Shkolnik added a comment - javadoc warning is related to "sun.security.krb5.PrincipalName is Sun proprietary API and may be removed in a future release" issue introduces elsewhere. committed to trunk.
        Hide
        Boris Shkolnik added a comment -

        no, it is newly introduced protocol.

        Show
        Boris Shkolnik added a comment - no, it is newly introduced protocol.
        Hide
        Jitendra Nath Pandey added a comment -

        Sorry, I missed one comment which I should have mentioned earlier.

        Do we need to increment the version number of RefreshUserMappingsProtocol.java?
        +1 apart from that.

        Show
        Jitendra Nath Pandey added a comment - Sorry, I missed one comment which I should have mentioned earlier. Do we need to increment the version number of RefreshUserMappingsProtocol.java? +1 apart from that.
        Hide
        Jitendra Nath Pandey added a comment -

        +1 for the patch

        Show
        Jitendra Nath Pandey added a comment - +1 for the patch
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12447728/HADOOP-6815-5.patch
        against trunk revision 956710.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/591/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/591/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/591/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/591/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12447728/HADOOP-6815-5.patch against trunk revision 956710. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 javadoc. The javadoc tool appears to have generated 1 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/591/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/591/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/591/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/591/console This message is automatically generated.
        Boris Shkolnik made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Boris Shkolnik made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Boris Shkolnik made changes -
        Attachment HADOOP-6815-5.patch [ 12447728 ]
        Boris Shkolnik made changes -
        Attachment HADOOP-6815-YH20-1.patch [ 12447718 ]
        Hide
        Boris Shkolnik added a comment -

        for previous version, not for commit

        Show
        Boris Shkolnik added a comment - for previous version, not for commit
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12447295/HADOOP-6815-3.patch
        against trunk revision 955438.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

        -1 javac. The patch appears to cause tar ant target to fail.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/588/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/588/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/588/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/588/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12447295/HADOOP-6815-3.patch against trunk revision 955438. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 javadoc. The javadoc tool appears to have generated 1 warning messages. -1 javac. The patch appears to cause tar ant target to fail. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/588/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/588/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/588/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/588/console This message is automatically generated.
        Boris Shkolnik made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Boris Shkolnik made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Boris Shkolnik made changes -
        Attachment HADOOP-6815-3.patch [ 12447295 ]
        Hide
        Devaraj Das added a comment -

        refreshUserToGroupsMappings() is also having the same client side configuration problem. Is there a separate ticket for this or is it being done in this issue itself?

        Yeah, although the conf is actually not used in the server (since the server already instantiated the Groups using the server's configuration), it is a good practice to not accept Configuration from clients for such commands... I'd propose that that issue is also addressed here...

        Show
        Devaraj Das added a comment - refreshUserToGroupsMappings() is also having the same client side configuration problem. Is there a separate ticket for this or is it being done in this issue itself? Yeah, although the conf is actually not used in the server (since the server already instantiated the Groups using the server's configuration), it is a good practice to not accept Configuration from clients for such commands... I'd propose that that issue is also addressed here...
        Hide
        Vinod Kumar Vavilapalli added a comment -

        refreshUserToGroupsMappings() is also having the same client side configuration problem. Is there a separate ticket for this or is it being done in this issue itself?

        Show
        Vinod Kumar Vavilapalli added a comment - refreshUserToGroupsMappings() is also having the same client side configuration problem. Is there a separate ticket for this or is it being done in this issue itself?
        Hide
        Jitendra Nath Pandey added a comment -

        +1

        Show
        Jitendra Nath Pandey added a comment - +1
        Boris Shkolnik made changes -
        Link This issue incorporates HDFS-1192 [ HDFS-1192 ]
        Boris Shkolnik made changes -
        Link This issue incorporates MAPREDUCE-1855 [ MAPREDUCE-1855 ]
        Boris Shkolnik made changes -
        Attachment HADOOP-6815-2.patch [ 12446815 ]
        Hide
        Boris Shkolnik added a comment -

        addressed comments

        Show
        Boris Shkolnik added a comment - addressed comments
        Hide
        Jitendra Nath Pandey added a comment -

        1. javadoc annotation @param cn for method refreshSuperUserGroupsConfiguration(Configuration conf) may cause warning.
        2. minor : It might be better to remove commented code //private static Configuration conf=null;

        Show
        Jitendra Nath Pandey added a comment - 1. javadoc annotation @param cn for method refreshSuperUserGroupsConfiguration(Configuration conf) may cause warning. 2. minor : It might be better to remove commented code //private static Configuration conf=null;
        Boris Shkolnik made changes -
        Attachment HADOOP-6815-1.patch [ 12446796 ]
        Hide
        Boris Shkolnik added a comment -

        fixed javadoc warning

        Show
        Boris Shkolnik added a comment - fixed javadoc warning
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12446780/HADOOP-6815.patch
        against trunk revision 953388.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/576/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/576/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/576/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/576/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12446780/HADOOP-6815.patch against trunk revision 953388. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 javadoc. The javadoc tool appears to have generated 1 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/576/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/576/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/576/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/576/console This message is automatically generated.
        Boris Shkolnik made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Boris Shkolnik made changes -
        Attachment HADOOP-6815.patch [ 12446780 ]
        Boris Shkolnik made changes -
        Field Original Value New Value
        Link This issue is blocked by HDFS-1192 [ HDFS-1192 ]
        Boris Shkolnik created issue -

          People

          • Assignee:
            Boris Shkolnik
            Reporter:
            Boris Shkolnik
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development