Hadoop Common
  1. Hadoop Common
  2. HADOOP-6794

Move configuration and script files post split

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: conf, scripts
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    1. HADOOP-6794.patch
      38 kB
      Tom White
    2. HADOOP-6794.patch
      37 kB
      Tom White
    3. HADOOP-6794.patch
      37 kB
      Tom White
    4. HADOOP-6794.patch
      37 kB
      Tom White
    5. HADOOP-6794.patch
      33 kB
      Tom White

      Issue Links

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Patch Available Patch Available Open Open
        1d 6h 26m 1 Tom White 02/Jun/10 06:11
        Open Open Patch Available Patch Available
        1h 3m 2 Tom White 02/Jun/10 06:11
        Patch Available Patch Available Resolved Resolved
        8d 18h 36m 1 Tom White 11/Jun/10 00:48
        Resolved Resolved Closed Closed
        74d 20h 55m 1 Tom White 24/Aug/10 21:43
        Tom White made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #310 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/310/)

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #310 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/310/ )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #363 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/363/)
        HADOOP-6794. Move configuration and script files post split. Includes HDFS-1181, MAPREDUCE-1033.

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #363 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/363/ ) HADOOP-6794 . Move configuration and script files post split. Includes HDFS-1181 , MAPREDUCE-1033 .
        Tom White made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Resolution Fixed [ 1 ]
        Hide
        Tom White added a comment -

        I've just committed this.

        Show
        Tom White added a comment - I've just committed this.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #293 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/293/)
        HADOOP-6794. Move configuration and script files post split. Includes HDFS-1181, MAPREDUCE-1033.

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #293 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/293/ ) HADOOP-6794 . Move configuration and script files post split. Includes HDFS-1181 , MAPREDUCE-1033 .
        Tom White made changes -
        Attachment HADOOP-6794.patch [ 12446302 ]
        Hide
        Tom White added a comment -

        A minor change to the patches which makes HADOOP_COMMON_HOME, HADOOP_HDFS_HOME, and HADOOP_MAPRED_HOME default to HADOOP_HOME if they are not set.

        Show
        Tom White added a comment - A minor change to the patches which makes HADOOP_COMMON_HOME, HADOOP_HDFS_HOME, and HADOOP_MAPRED_HOME default to HADOOP_HOME if they are not set.
        Tom White made changes -
        Attachment HADOOP-6794.patch [ 12446200 ]
        Hide
        Tom White added a comment -

        A minor change that loosens the jar glob pattern at the top-level from hadoop-common-.jar to hadoop-.jar. This change supports an installation where all the scripts, configuration and jars are in common directories, as produced by HADOOP-6342. I successfully ran a job on a pseudo-distributed cluster in this mode.

        Show
        Tom White added a comment - A minor change that loosens the jar glob pattern at the top-level from hadoop-common- .jar to hadoop- .jar . This change supports an installation where all the scripts, configuration and jars are in common directories, as produced by HADOOP-6342 . I successfully ran a job on a pseudo-distributed cluster in this mode.
        Hide
        Tom White added a comment -

        Thanks for the review, Vinod. I plan to commit these three patches soon.

        Show
        Tom White added a comment - Thanks for the review, Vinod. I plan to commit these three patches soon.
        Hide
        Vinod Kumar Vavilapalli added a comment -

        The latest patches for the three projects look good, Tom. I could use HADOOP-6461 to successfully bring up single node clusters of both hdfs and mapreduce. I ran a simple mapreduce job too.

        +1.

        Thanks for taking this up!

        Show
        Vinod Kumar Vavilapalli added a comment - The latest patches for the three projects look good, Tom. I could use HADOOP-6461 to successfully bring up single node clusters of both hdfs and mapreduce. I ran a simple mapreduce job too. +1. Thanks for taking this up!
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12446104/HADOOP-6794.patch
        against trunk revision 950309.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 12 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/72/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/72/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/72/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/72/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12446104/HADOOP-6794.patch against trunk revision 950309. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 12 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/72/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/72/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/72/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/72/console This message is automatically generated.
        Tom White made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Tom White made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Tom White made changes -
        Attachment HADOOP-6794.patch [ 12446104 ]
        Hide
        Tom White added a comment -

        Updated to pick up webapps from the classpath. With this change (and HADOOP-6461) the web UIs work correctly.

        Show
        Tom White added a comment - Updated to pick up webapps from the classpath. With this change (and HADOOP-6461 ) the web UIs work correctly.
        Tom White made changes -
        Attachment HADOOP-6794.patch [ 12446072 ]
        Hide
        Tom White added a comment -

        Vinod, many thanks for the thorough review. I've made fixes for all the errors you pointed out. Common's conf/log4j.properties is now a merged superset of the log4j.properties - I think we can split it out further later as needed.

        I tried running with different installation directories, and successfully ran a job in pseudo-distributed mode. However, I did notice that the web UIs were not working, which I think will be fixed as a part of HADOOP-6461, although I'm still investigating that.

        Show
        Tom White added a comment - Vinod, many thanks for the thorough review. I've made fixes for all the errors you pointed out. Common's conf/log4j.properties is now a merged superset of the log4j.properties - I think we can split it out further later as needed. I tried running with different installation directories, and successfully ran a job in pseudo-distributed mode. However, I did notice that the web UIs were not working, which I think will be fixed as a part of HADOOP-6461 , although I'm still investigating that.
        Hide
        Vinod Kumar Vavilapalli added a comment -

        The following need to be added to the patch.

        conf/hadoop-policy.xml.template:

        • security.admin.operations.protocol.acl configuration property is not present in common-project but is present and needed in mapreduce.

        conf/log4j.properties

        • Nine settings for 'Job Summary Appender' are present and needed in mapreduce project but are not there in common project.
        • Two settings for mapreduce task logs are present and needed in mapreduce project but are not there in common project.
          • hadoop.tasklog.iscleanup=false
          • log4j.appender.TLA.isCleanup=$ {hadoop.tasklog.iscleanup}
        • One more thing: copying this file over from mapreduce will not work because six settings for 'Security appender' are in common but not present in the mapreduce project's log4j.properties file.

        May be we should also split both the above files per project. But that may be long term, will open a separate ticket if you agree.

        Other issues

        • Minor: bin/rcc still refers to hadoop-core at one place.
        • when i run `ant binary` in hdfs bin directory isn't getting copied into the packaged binary, neither are the hdfs script files copied.
        • when i run `ant binary` in mapreduce, files aren't getting copied into the packaged bin directory

        Verified the rest of the changes in all the three patches, they look good.

        Still couldn't get the cluster up with different installation directories, will be trying in the meanwhile..

        Show
        Vinod Kumar Vavilapalli added a comment - The following need to be added to the patch. conf/hadoop-policy.xml.template: security.admin.operations.protocol.acl configuration property is not present in common-project but is present and needed in mapreduce. conf/log4j.properties Nine settings for 'Job Summary Appender' are present and needed in mapreduce project but are not there in common project. Two settings for mapreduce task logs are present and needed in mapreduce project but are not there in common project. hadoop.tasklog.iscleanup=false log4j.appender.TLA.isCleanup=$ {hadoop.tasklog.iscleanup} One more thing: copying this file over from mapreduce will not work because six settings for 'Security appender' are in common but not present in the mapreduce project's log4j.properties file. May be we should also split both the above files per project. But that may be long term, will open a separate ticket if you agree. Other issues Minor: bin/rcc still refers to hadoop-core at one place. when i run `ant binary` in hdfs bin directory isn't getting copied into the packaged binary, neither are the hdfs script files copied. when i run `ant binary` in mapreduce, files aren't getting copied into the packaged bin directory Verified the rest of the changes in all the three patches, they look good. Still couldn't get the cluster up with different installation directories, will be trying in the meanwhile..
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12445968/HADOOP-6794.patch
        against trunk revision 949658.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 12 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/555/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/555/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/555/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/555/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12445968/HADOOP-6794.patch against trunk revision 949658. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 12 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/555/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/555/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/555/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/555/console This message is automatically generated.
        Tom White made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Tom White made changes -
        Attachment HADOOP-6794.patch [ 12445968 ]
        Show
        Tom White added a comment - See https://issues.apache.org/jira/browse/MAPREDUCE-1033?focusedCommentId=12873810&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12873810
        Tom White made changes -
        Link This issue is part of HDFS-1181 [ HDFS-1181 ]
        Tom White made changes -
        Field Original Value New Value
        Link This issue is part of MAPREDUCE-1033 [ MAPREDUCE-1033 ]
        Tom White created issue -

          People

          • Assignee:
            Tom White
            Reporter:
            Tom White
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development