[HADOOP-6788] [Herriot] Exception exclusion functionality is not working correctly.

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.21.0
• Fix Version/s: 0.21.0
• Component/s: test
• Hadoop Flags: Reviewed
• Tags: herriot
• Assignee: Vinay Kumar Thota
• Reporter: Vinay Kumar Thota
• Created: 17/May/10 10:40
• Updated: 02/May/13 02:29
• Resolved: 04/Jun/10 04:13

Description

Exception exclusion functionality is not working correctly because of that tests are failing by not matching the error count.
I debugged the issue and found that the problem with shell command which is generating in the getNumberOfMatchesInLogFile function.

Currently building the shell command in the following way.

if(list != null){
for(int i =0; i < list.length; ++i)

{ filePattern.append(" | grep -v " + list[i] ); }

}
String[] cmd =
new String[] {
"bash",
"-c",
"grep -c "
+ pattern + " " + filePattern
+ " | awk -F: '

{s+=$2} END {print s}'" };

However, The above commnad won't work correctly because you are counting the exceptions in the file before excluding the known exceptions.
In this case it gives the mismatch error counts everytime.The shell command should be in the following way to work correctly.

if (list != null) {
int index = 0;
for (String excludeExp : list) { filePattern.append((++index < list.length)? "| grep -v " : "| grep -vc " + list[i] ); }
}
String[] cmd =
new String[] {
"bash",
"-c",
"grep "
+ pattern + " " + filePattern
+ " | awk -F: '{s+=$2}

END

{print s}

'" };

Issue Links

• depends upon: HADOOP-6332 Large-scale Automated Test Framework