Hadoop Common
  1. Hadoop Common
  2. HADOOP-6763

Remove verbose logging from the Groups class

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.21.0
    • Fix Version/s: 0.22.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      2010-02-25 08:30:52,269 INFO security.Groups (Groups.java:<init>(60)) - Group m
      apping impl=org.apache.hadoop.security.ShellBasedUnixGroupsMapping; cacheTimeout
      =300000
      ...
      2010-02-25 08:30:57,872 INFO security.Groups (Groups.java:getGroups(76)) - Retu
      rning cached groups for 'oom'

      should both be demoted to debug level.

      1. HADOOP-6763.patch
        0.7 kB
        Boris Shkolnik
      2. HADOOP-6598-BP20-Fix.patch
        0.7 kB
        Boris Shkolnik
      3. HADOOP-6598-BP20.patch
        1.0 kB
        Boris Shkolnik
      4. HADOOP-6598.patch
        1.0 kB
        Boris Shkolnik

        Activity

        Hide
        Boris Shkolnik added a comment -

        HADOOP-6598-BP20.patch - for previous verson, not for commit

        Show
        Boris Shkolnik added a comment - HADOOP-6598 -BP20.patch - for previous verson, not for commit
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12438060/HADOOP-6598.patch
        against trunk revision 918880.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/410/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/410/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/410/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/410/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12438060/HADOOP-6598.patch against trunk revision 918880. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/410/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/410/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/410/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/410/console This message is automatically generated.
        Hide
        Jitendra Nath Pandey added a comment -

        +1

        Show
        Jitendra Nath Pandey added a comment - +1
        Hide
        Boris Shkolnik added a comment -

        one more case of excessive LOG.info. Changed to debug. For previous version, not for commit.

        Show
        Boris Shkolnik added a comment - one more case of excessive LOG.info. Changed to debug. For previous version, not for commit.
        Hide
        Jakob Homan added a comment -

        Looks like HADOOP-6717 partially duplicated this work and has been committed. We should update the patch.

        Show
        Jakob Homan added a comment - Looks like HADOOP-6717 partially duplicated this work and has been committed. We should update the patch.
        Hide
        Jakob Homan added a comment -

        Canceling patch.

        Show
        Jakob Homan added a comment - Canceling patch.
        Hide
        Boris Shkolnik added a comment -

        moved by mistake. moving back to COMMON.

        Show
        Boris Shkolnik added a comment - moved by mistake. moving back to COMMON.
        Hide
        Jakob Homan added a comment -

        +1

        Show
        Jakob Homan added a comment - +1
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12444412/HADOOP-6763.patch
        against trunk revision 941662.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/518/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/518/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/518/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/518/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12444412/HADOOP-6763.patch against trunk revision 941662. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/518/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/518/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/518/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/518/console This message is automatically generated.
        Hide
        Boris Shkolnik added a comment -

        no test - debug change only.

        committed to trunk

        Show
        Boris Shkolnik added a comment - no test - debug change only. committed to trunk
        Hide
        Gabriele Kahlout added a comment -

        why didn't this make into a release (I'm using 0.21.0)?

        Show
        Gabriele Kahlout added a comment - why didn't this make into a release (I'm using 0.21.0)?
        Hide
        Boris Shkolnik added a comment -

        it was committed to trunk on in May 2010. If 0.21 was cut before that, then the fix needs to be ported manually to it.

        Show
        Boris Shkolnik added a comment - it was committed to trunk on in May 2010. If 0.21 was cut before that, then the fix needs to be ported manually to it.
        Hide
        Gabriele Kahlout added a comment -

        okay, then shouldn't the fix version be set to 0.22?

        Show
        Gabriele Kahlout added a comment - okay, then shouldn't the fix version be set to 0.22?
        Hide
        Gabriele Kahlout added a comment -

        $ svn co -r 941662 http://svn.apache.org/repos/asf/hadoop/common/branches/branch-0.21/ hadoop
        $ ant -f hadoop/build.xml

        I still get verbose logging at each command
        11/05/11 22:45:39 INFO security.Groups: Group mapping impl=org.apache.hadoop.security.ShellBasedUnixGroupsMapping; cacheTimeout=300000

        Show
        Gabriele Kahlout added a comment - $ svn co -r 941662 http://svn.apache.org/repos/asf/hadoop/common/branches/branch-0.21/ hadoop $ ant -f hadoop/build.xml I still get verbose logging at each command 11/05/11 22:45:39 INFO security.Groups: Group mapping impl=org.apache.hadoop.security.ShellBasedUnixGroupsMapping; cacheTimeout=300000
        Hide
        Tom White added a comment -

        Yes, this should have fix version 0.22.

        Show
        Tom White added a comment - Yes, this should have fix version 0.22.

          People

          • Assignee:
            Boris Shkolnik
            Reporter:
            Owen O'Malley
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development