Boris Shkolnik added a comment - 04/May/10 17:35 previous version, not for commit

Jitendra Nath Pandey added a comment - 05/May/10 00:26 @return should be added for getRpcMetrics javadoc. +1 otherwise

Boris Shkolnik added a comment - 05/May/10 16:10 addressed Jitendra's comment.

Jitendra Nath Pandey added a comment - 27/Jul/10 23:09 Patch for trunk.

Hadoop QA added a comment - 27/Jul/10 23:40 -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12450644/HADOOP-6745.1.patch against trunk revision 979785. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javadoc. The javadoc tool appears to have generated 1 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/642/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/642/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/642/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/642/console This message is automatically generated.

Jitendra Nath Pandey added a comment - 28/Jul/10 00:49 The javadoc warnings are in KerberosName.java and SecurityUtil.java which are related to kerberos API and are unrelated to this patch. No tests included because this patch changes only javadocs.

Jakob Homan added a comment - 28/Jul/10 00:54 +1

Jakob Homan added a comment - 28/Jul/10 00:58 I've committed this. Thanks Jitendra and Boris. Resolving as fixed.