Hadoop Common
  1. Hadoop Common
  2. HADOOP-6745

adding some java doc to Server.RpcMetrics, UGI

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0
    • Component/s: ipc
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    1. HADOOP-6745.1.patch
      4 kB
      Jitendra Nath Pandey
    2. HADOOP-6745-BP20-2.patch
      4 kB
      Boris Shkolnik
    3. HADOOP-6745-BP20-1.patch
      4 kB
      Boris Shkolnik

      Activity

      Hide
      Boris Shkolnik added a comment -

      previous version, not for commit

      Show
      Boris Shkolnik added a comment - previous version, not for commit
      Hide
      Jitendra Nath Pandey added a comment -

      @return should be added for getRpcMetrics javadoc.

      +1 otherwise

      Show
      Jitendra Nath Pandey added a comment - @return should be added for getRpcMetrics javadoc. +1 otherwise
      Hide
      Boris Shkolnik added a comment -

      addressed Jitendra's comment.

      Show
      Boris Shkolnik added a comment - addressed Jitendra's comment.
      Hide
      Jitendra Nath Pandey added a comment -

      Patch for trunk.

      Show
      Jitendra Nath Pandey added a comment - Patch for trunk.
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12450644/HADOOP-6745.1.patch
      against trunk revision 979785.

      +1 @author. The patch does not contain any @author tags.

      -1 tests included. The patch doesn't appear to include any new or modified tests.
      Please justify why no new tests are needed for this patch.
      Also please list what manual steps were performed to verify this patch.

      -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 findbugs. The patch does not introduce any new Findbugs warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 core tests. The patch passed core unit tests.

      +1 contrib tests. The patch passed contrib unit tests.

      Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/642/testReport/
      Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/642/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
      Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/642/artifact/trunk/build/test/checkstyle-errors.html
      Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/642/console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12450644/HADOOP-6745.1.patch against trunk revision 979785. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javadoc. The javadoc tool appears to have generated 1 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/642/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/642/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/642/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/642/console This message is automatically generated.
      Hide
      Jitendra Nath Pandey added a comment -

      The javadoc warnings are in KerberosName.java and SecurityUtil.java which are related to kerberos API and are unrelated to this patch.

      No tests included because this patch changes only javadocs.

      Show
      Jitendra Nath Pandey added a comment - The javadoc warnings are in KerberosName.java and SecurityUtil.java which are related to kerberos API and are unrelated to this patch. No tests included because this patch changes only javadocs.
      Hide
      Jakob Homan added a comment -

      +1

      Show
      Jakob Homan added a comment - +1
      Hide
      Jakob Homan added a comment -

      I've committed this. Thanks Jitendra and Boris. Resolving as fixed.

      Show
      Jakob Homan added a comment - I've committed this. Thanks Jitendra and Boris. Resolving as fixed.

        People

        • Assignee:
          Boris Shkolnik
          Reporter:
          Boris Shkolnik
        • Votes:
          0 Vote for this issue
          Watchers:
          1 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development