[HADOOP-6702] Incorrect exit codes for "dfs -chown", "dfs -chgrp" when input is given in wildcard format.

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.19.1, 0.20.0, 0.20.1, 0.20.2
• Fix Version/s: 0.20.3, 0.21.0, 0.22.0
• Component/s: fs
• Assignee: Ravi Phulari
• Reporter: Ravi Phulari
• Created: 13/Apr/10 21:09
• Updated: 09/Mar/11 15:36
• Resolved: 10/May/10 22:17

Description

Currently incorrect exit codes are given for "dfs -chown", "dfs -chgrp" when input is given in wildcard format.

This bug is due to missing update of errors count in FsShell.java.

FsShell.java

int runCmdHandler(CmdHandler handler, String[] args,
                                   int startIndex, boolean recursive) 
                                   throws IOException {
    int errors = 0;
    
    for (int i=startIndex; i<args.length; i++) {
      Path srcPath = new Path(args[i]);
      FileSystem srcFs = srcPath.getFileSystem(getConf());
      Path[] paths = FileUtil.stat2Paths(srcFs.globStatus(srcPath), srcPath);
      for(Path path : paths) {
        try {
          FileStatus file = srcFs.getFileStatus(path);
          if (file == null) {
            System.err.println(handler.getName() + 
                               ": could not get status for '" + path + "'");
            errors++;
          } else {
            errors += runCmdHandler(handler, file, srcFs, recursive);
          }
        } catch (IOException e) {
          String msg = (e.getMessage() != null ? e.getLocalizedMessage() :
            (e.getCause().getMessage() != null ? 
                e.getCause().getLocalizedMessage() : "null"));
          System.err.println(handler.getName() + ": could not get status for '"
                                        + path + "': " + msg.split("\n")[0]);
          errors++;
        }
      }
    }
 

If there are no files on HDFS matching to wildcard input then srcFs.globStatus(srcpath) returns 0.
{{ Path[] paths = FileUtil.stat2Paths(srcFs.globStatus(srcPath), srcPath);}}

Resulting no increment in errors and command exits with 0 even though file/directory does not exist.

Issue Links

• relates to: HADOOP-6701 Incorrect exit codes for "dfs -chown", "dfs -chgrp"
• requires: HDFS-1736 Break dependency between DatanodeJspHelper and FsShell