Hadoop Common
  1. Hadoop Common
  2. HADOOP-6687

user object in the subject in UGI should be reused in case of a relogin.

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In case of a relogin, a new user object is created in the subject. This causes the subject to lose some state for example authentication method. Instead, a new user object should not be added to the subject if one is already present.

      1. HADOOP-6687.3.patch
        2 kB
        Jitendra Nath Pandey
      2. HADOOP-6687.2.patch
        2 kB
        Jitendra Nath Pandey
      3. HADOOP-6687-y20.2.patch
        0.6 kB
        Jitendra Nath Pandey

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #360 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/360/)
        HADOOP-6687. user object in the subject in UGI should be reused in case of a relogin.

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #360 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/360/ ) HADOOP-6687 . user object in the subject in UGI should be reused in case of a relogin.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #284 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/284/)
        HADOOP-6687. user object in the subject in UGI should be reused in case of a relogin.

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #284 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/284/ ) HADOOP-6687 . user object in the subject in UGI should be reused in case of a relogin.
        Hide
        Boris Shkolnik added a comment -

        thanks Jitendra.

        Show
        Boris Shkolnik added a comment - thanks Jitendra.
        Hide
        Boris Shkolnik added a comment -

        +1
        committed to trunk

        Show
        Boris Shkolnik added a comment - +1 committed to trunk
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12446509/HADOOP-6687.3.patch
        against trunk revision 951624.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/570/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/570/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/570/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/570/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12446509/HADOOP-6687.3.patch against trunk revision 951624. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/570/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/570/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/570/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/570/console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12446391/HADOOP-6687.2.patch
        against trunk revision 951624.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/77/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/77/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/77/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/77/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12446391/HADOOP-6687.2.patch against trunk revision 951624. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/77/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/77/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/77/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/77/console This message is automatically generated.
        Hide
        Jitendra Nath Pandey added a comment -

        Patch for trunk.

        Show
        Jitendra Nath Pandey added a comment - Patch for trunk.
        Hide
        Jitendra Nath Pandey added a comment -

        The patch is against yahoo-hadoop-20, which has the security code. I should have clarified that.
        It will be forward ported to trunk.

        Show
        Jitendra Nath Pandey added a comment - The patch is against yahoo-hadoop-20, which has the security code. I should have clarified that. It will be forward ported to trunk.
        Hide
        Kang Xiao added a comment -

        Which revision is the patch against? Since no such method "public boolean commit() throws LoginException" found in http://svn.apache.org/repos/asf/hadoop/common/branches/branch-0.20/src/core/org/apache/hadoop/security/UserGroupInformation.java.

        Show
        Kang Xiao added a comment - Which revision is the patch against? Since no such method "public boolean commit() throws LoginException" found in http://svn.apache.org/repos/asf/hadoop/common/branches/branch-0.20/src/core/org/apache/hadoop/security/UserGroupInformation.java .
        Hide
        Jitendra Nath Pandey added a comment -

        Patch for hadoop-20 added.

        Show
        Jitendra Nath Pandey added a comment - Patch for hadoop-20 added.

          People

          • Assignee:
            Jitendra Nath Pandey
            Reporter:
            Jitendra Nath Pandey
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development