Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.22.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Unfortunately we've missed some javac, javadoc, findbugs warnings in the recent security work.

      1. C6642-0y20.patch
        36 kB
        Chris Douglas
      2. C6642-1y20.patch
        36 kB
        Chris Douglas
      3. C6642-1y20-debug.patch
        0.6 kB
        Chris Douglas
      4. common-6642-trunk.patch
        3 kB
        Po Cheung

        Issue Links

          Activity

          Hide
          Chris Douglas added a comment -

          Merge w/ HEAD

          Show
          Chris Douglas added a comment - Merge w/ HEAD
          Hide
          Chris Douglas added a comment -

          Includes MAPREDUCE-623

          Show
          Chris Douglas added a comment - Includes MAPREDUCE-623
          Hide
          Chris Douglas added a comment -

          Accidentally caught CHANGES.txt

          Show
          Chris Douglas added a comment - Accidentally caught CHANGES.txt
          Hide
          Chris Douglas added a comment -

          Remove debug stmt

          Show
          Chris Douglas added a comment - Remove debug stmt
          Hide
          Po Cheung added a comment -

          The original patch by Chris has been cleaned up and split into 3 separate patches. Some fixes in the original patch have already been applied in MAPREDUCE-623.

          The new consolidated patches fix the following:

          • Convert KRB5_CIPHER_SUITES from type String[] to List<String>
          • Remove redundant toString methods
          • Replace hardcoded time constant with TimeUnit
          • Add @Override
          • Replace iterator for loop with enhanced for loop from JDK 1.5
          • Remove unused private field

          The patches have been tested against trunk and 0.22 branch.

          Show
          Po Cheung added a comment - The original patch by Chris has been cleaned up and split into 3 separate patches. Some fixes in the original patch have already been applied in MAPREDUCE-623 . The new consolidated patches fix the following: Convert KRB5_CIPHER_SUITES from type String[] to List<String> Remove redundant toString methods Replace hardcoded time constant with TimeUnit Add @Override Replace iterator for loop with enhanced for loop from JDK 1.5 Remove unused private field The patches have been tested against trunk and 0.22 branch.
          Hide
          Konstantin Shvachko added a comment -

          Looks like this patch is for mapreduce project, not common.
          Po, you should create a new MAPREDUCE issue and link it to this jira.

          Show
          Konstantin Shvachko added a comment - Looks like this patch is for mapreduce project, not common. Po, you should create a new MAPREDUCE issue and link it to this jira.
          Hide
          Po Cheung added a comment -

          Thanks Konstantin.

          Created two new issues: HDFS-1591 and MAPREDUCE-2281 and moved the hdfs and mapreduce patches over.

          Show
          Po Cheung added a comment - Thanks Konstantin. Created two new issues: HDFS-1591 and MAPREDUCE-2281 and moved the hdfs and mapreduce patches over.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12468818/common-6642-trunk.patch
          against trunk revision 1065901.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/213//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/213//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/213//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12468818/common-6642-trunk.patch against trunk revision 1065901. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/213//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/213//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/213//console This message is automatically generated.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #492 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/492/)
          HADOOP-6642. Fix javac, javadoc, findbugs warnings related to security work. Contributed by Chris Douglas, Po Cheung.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #492 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/492/ ) HADOOP-6642 . Fix javac, javadoc, findbugs warnings related to security work. Contributed by Chris Douglas, Po Cheung.
          Hide
          Konstantin Shvachko added a comment -

          I just committed this. Thank you Po and Chris.

          Somebody will need to publish the common artifact manually. Or it will break hdfs and mr.

          Show
          Konstantin Shvachko added a comment - I just committed this. Thank you Po and Chris. Somebody will need to publish the common artifact manually. Or it will break hdfs and mr.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #593 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/593/)
          HADOOP-6642. Fix javac, javadoc, findbugs warnings related to security work. Contributed by Chris Douglas, Po Cheung.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #593 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/593/ ) HADOOP-6642 . Fix javac, javadoc, findbugs warnings related to security work. Contributed by Chris Douglas, Po Cheung.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-22-branch #23 (See https://hudson.apache.org/hudson/job/Hadoop-Common-22-branch/23/)
          HADOOP-6642. Merge from trunk to branch 0.22.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-22-branch #23 (See https://hudson.apache.org/hudson/job/Hadoop-Common-22-branch/23/ ) HADOOP-6642 . Merge from trunk to branch 0.22.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #595 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/595/)

          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #595 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/595/ )
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #539 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/539/)

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #539 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/539/ )
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-22-branch #33 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-22-branch/33/)

          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-22-branch #33 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-22-branch/33/ )
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #643 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk/643/)

          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #643 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk/643/ )
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #643 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/643/)

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #643 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/643/ )
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-22-branch #35 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-22-branch/35/)

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-22-branch #35 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-22-branch/35/ )

            People

            • Assignee:
              Po Cheung
              Reporter:
              Arun C Murthy
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development