[HADOOP-6631] FileUtil.fullyDelete() should continue to delete other files despite failure at any level.

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.21.0
• Component/s: fs, util
• Hadoop Flags: Reviewed
• Assignee: Ravi Gummadi
• Reporter: Vinod Kumar Vavilapalli
• Created: 12/Mar/10 10:01
• Updated: 24/Aug/10 20:42
• Resolved: 06/May/10 11:27

Description

Ravi commented about this on HADOOP-6536. Paraphrasing...

Currently FileUtil.fullyDelete(myDir) comes out stopping deletion of other files/directories if it is unable to delete a file/dir(say because of not having permissions to delete that file/dir) anywhere under myDir. This is because we return from method if the recursive call "if(!fullyDelete())

{return false;}

" fails at any level of recursion.

Shouldn't it continue with deletion of other files/dirs continuing in the for loop instead of returning false here ?

I guess fullyDelete() should delete as many files as possible(similar to 'rm -rf').

Issue Links

• is related to: HADOOP-6688 FileSystem.delete(...) implementations should not throw FileNotFoundException