Hadoop Common
  1. Hadoop Common
  2. HADOOP-6620

NPE if renewer is passed as null in getDelegationToken

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.22.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      If renewer is passed as null in getDelegationToken, an NPE is thrown. We should handle null renewer and the token must not be allowed to be renewed if the renewer is null or empty string.

      1. HADOOP-6620.2.patch
        5 kB
        Jitendra Nath Pandey
      2. HADOOP-6620-y20.1.patch
        5 kB
        Jitendra Nath Pandey

        Issue Links

          Activity

          Jitendra Nath Pandey created issue -
          Jitendra Nath Pandey made changes -
          Field Original Value New Value
          Assignee Jitendra Nath Pandey [ jnp ]
          Jitendra Nath Pandey made changes -
          Attachment HADOOP-6620-y20.1.patch [ 12438072 ]
          Hide
          Jitendra Nath Pandey added a comment -

          Patch for trunk uploaded and submitted for hudson.

          Show
          Jitendra Nath Pandey added a comment - Patch for trunk uploaded and submitted for hudson.
          Jitendra Nath Pandey made changes -
          Attachment HADOOP-6620.2.patch [ 12438074 ]
          Jitendra Nath Pandey made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12438074/HADOOP-6620.2.patch
          against trunk revision 918880.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/32/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/32/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/32/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/32/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12438074/HADOOP-6620.2.patch against trunk revision 918880. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/32/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/32/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/32/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/32/console This message is automatically generated.
          Hide
          Boris Shkolnik added a comment -

          +1
          Nitpick.. I would use (renewer!=null)?renewer:new Text(); in this case..

          Show
          Boris Shkolnik added a comment - +1 Nitpick.. I would use (renewer!=null)?renewer:new Text(); in this case..
          Boris Shkolnik made changes -
          Hadoop Flags [Reviewed]
          Jitendra Nath Pandey made changes -
          Link This issue incorporates HADOOP-6621 [ HADOOP-6621 ]
          Hide
          Jakob Homan added a comment -

          I've committed this. Thanks, Jitendra! Resolving as fixed.

          Show
          Jakob Homan added a comment - I've committed this. Thanks, Jitendra! Resolving as fixed.
          Jakob Homan made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Fix Version/s 0.22.0 [ 12314296 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #364 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/364/)
          HADOOP-6620. NPE if renewer is passed as null in getDelegationToken. Contributed by Jitendra Pandey.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #364 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/364/ ) HADOOP-6620 . NPE if renewer is passed as null in getDelegationToken. Contributed by Jitendra Pandey.
          Konstantin Shvachko made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          3h 33m 1 Jitendra Nath Pandey 06/Mar/10 02:42
          Patch Available Patch Available Resolved Resolved
          97d 20h 6m 1 Jakob Homan 11/Jun/10 22:49
          Resolved Resolved Closed Closed
          548d 7h 29m 1 Konstantin Shvachko 12/Dec/11 06:18

            People

            • Assignee:
              Jitendra Nath Pandey
              Reporter:
              Jitendra Nath Pandey
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development