Hadoop Common
  1. Hadoop Common
  2. HADOOP-6593

TextRecordInputStream doesn't close SequenceFile.Reader

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.20.1
    • Fix Version/s: 0.21.0
    • Component/s: fs
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Using hadoop fs -text on a glob with many sequence files can fail with too many open file handles.

      The cause seems to be that TextRecordInputStream doesn't override close(), so printToStdout's call to close doesn't release the SequenceFile.Reader.

      1. HADOOP-6593.patch
        0.5 kB
        Chase Bradford

        Activity

        Hide
        Chase Bradford added a comment -

        Added an override for close() in FsShell.TextRecordInputStream that closes the SequenceFile.Reader instance. I didn't create new tests because I don't know the best way to force too many open file handles on the test machine. However, with this patch I can set ulimit -n 100 and still use the -text option on a path glob with 1000+ files. Without the patch, files fail to open at the 95th part.

        Show
        Chase Bradford added a comment - Added an override for close() in FsShell.TextRecordInputStream that closes the SequenceFile.Reader instance. I didn't create new tests because I don't know the best way to force too many open file handles on the test machine. However, with this patch I can set ulimit -n 100 and still use the -text option on a path glob with 1000+ files. Without the patch, files fail to open at the 95th part.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12437342/HADOOP-6593.patch
        against trunk revision 916915.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/399/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/399/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/399/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/399/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12437342/HADOOP-6593.patch against trunk revision 916915. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/399/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/399/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/399/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/399/console This message is automatically generated.
        Hide
        Tom White added a comment -

        +1 I've just committed this. Thanks Chase!

        Show
        Tom White added a comment - +1 I've just committed this. Thanks Chase!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #204 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/204/)
        . TextRecordInputStream doesn't close SequenceFile.Reader. Contributed by Chase Bradford.

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #204 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/204/ ) . TextRecordInputStream doesn't close SequenceFile.Reader. Contributed by Chase Bradford.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #282 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/282/)
        . TextRecordInputStream doesn't close SequenceFile.Reader. Contributed by Chase Bradford.

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #282 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/282/ ) . TextRecordInputStream doesn't close SequenceFile.Reader. Contributed by Chase Bradford.

          People

          • Assignee:
            Chase Bradford
            Reporter:
            Chase Bradford
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development