Hadoop Common
  1. Hadoop Common
  2. HADOOP-6583

Capture metrics for authentication/authorization at the RPC layer

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.21.0
    • Component/s: ipc, security
    • Labels:
      None

      Description

      Define metrics for authentication/authorization for the RPC layer.

      1. 6583-bp20.patch
        5 kB
        Devaraj Das
      2. 6583-2.patch
        5 kB
        Devaraj Das
      3. 6583-1.patch
        13 kB
        Devaraj Das

        Activity

        Hide
        Devaraj Das added a comment -

        The authentication/authorization successes/failures are captured.

        Show
        Devaraj Das added a comment - The authentication/authorization successes/failures are captured.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12436504/6583-1.patch
        against trunk revision 912207.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/25/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12436504/6583-1.patch against trunk revision 912207. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/25/console This message is automatically generated.
        Hide
        Devaraj Das added a comment -

        Had forgotten to update my local repository before creating the patch. In this patch, I also changed the approach to use the existing RpcMetrics instead of defining a new one for security.

        Show
        Devaraj Das added a comment - Had forgotten to update my local repository before creating the patch. In this patch, I also changed the approach to use the existing RpcMetrics instead of defining a new one for security.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12436516/6583-2.patch
        against trunk revision 912207.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/26/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/26/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/26/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/26/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12436516/6583-2.patch against trunk revision 912207. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/26/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/26/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/26/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/26/console This message is automatically generated.
        Hide
        Owen O'Malley added a comment -

        +1

        Show
        Owen O'Malley added a comment - +1
        Hide
        Devaraj Das added a comment -

        I just committed this.

        Show
        Devaraj Das added a comment - I just committed this.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #180 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/180/)
        . Captures authentication and authorization metrics. Contributed by Devaraj Das.

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #180 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/180/ ) . Captures authentication and authorization metrics. Contributed by Devaraj Das.
        Hide
        Devaraj Das added a comment -

        Patch for Y20. Not for commit here.

        Show
        Devaraj Das added a comment - Patch for Y20. Not for commit here.
        Hide
        Boris Shkolnik added a comment -

        by putting authenticationSuccesses.inc() into processOneRpc() , you are counting all RPC calls, including heartBeats.
        Is this what we want?

        Show
        Boris Shkolnik added a comment - by putting authenticationSuccesses.inc() into processOneRpc() , you are counting all RPC calls, including heartBeats. Is this what we want?
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #258 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/258/)
        . Captures authentication and authorization metrics. Contributed by Devaraj Das.

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #258 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/258/ ) . Captures authentication and authorization metrics. Contributed by Devaraj Das.

          People

          • Assignee:
            Devaraj Das
            Reporter:
            Devaraj Das
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development