Hadoop Common
  1. Hadoop Common
  2. HADOOP-6560

HarFileSystem throws NPE for har://hdfs-/foo

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: fs
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      -bash-3.1$ hadoop distcp -Dmapred.job.queue.name=${JOBQ}  har://hdfs-/user/tsz/t10_4.har/t10_4 t10_4_distcp t10_4_distcp
      10/01/28 23:20:45 INFO tools.DistCp: srcPaths=[har://hdfs-/user/tsz/t10_4.har/t10_4]
      10/01/28 23:20:45 INFO tools.DistCp: destPath=t10_4_distcp
      With failures, global counters are inaccurate; consider running with -i
      Copy failed: java.lang.NullPointerException
              at org.apache.hadoop.fs.HarFileSystem.decodeHarURI(HarFileSystem.java:184)
              at org.apache.hadoop.fs.HarFileSystem.initialize(HarFileSystem.java:95)
              ...
      
      1. c6560_20100211.patch
        1 kB
        Tsz Wo Nicholas Sze
      2. c6560_20100212.patch
        3 kB
        Tsz Wo Nicholas Sze
      3. c6560_20100212_y0.20.patch
        2 kB
        Tsz Wo Nicholas Sze

        Issue Links

          Activity

          Hide
          Tsz Wo Nicholas Sze added a comment -

          Moved this from MapReduce to Common since this is a fs issue.

          Show
          Tsz Wo Nicholas Sze added a comment - Moved this from MapReduce to Common since this is a fs issue.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          c6560_20100211.patch: throws IOException instead of NPE.

          Show
          Tsz Wo Nicholas Sze added a comment - c6560_20100211.patch: throws IOException instead of NPE.
          Hide
          steve_l added a comment -

          patch looks good but could add a test. I also think the i == host.length()? bit could have braces as I first misread it as host.length()?, which is of course legit C/C++, and left me feeling very confused.

          Show
          steve_l added a comment - patch looks good but could add a test. I also think the i == host.length()? bit could have braces as I first misread it as host.length()? , which is of course legit C/C++, and left me feeling very confused.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Thanks Steve for looking at it.

          c6560_20100212.patch: added a test.

          Show
          Tsz Wo Nicholas Sze added a comment - Thanks Steve for looking at it. c6560_20100212.patch: added a test.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12435753/c6560_20100212.patch
          against trunk revision 909806.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/358/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/358/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/358/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/358/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12435753/c6560_20100212.patch against trunk revision 909806. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/358/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/358/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/358/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/358/console This message is automatically generated.
          Hide
          Mahadev konar added a comment -

          +1 the patch looks good.

          Show
          Mahadev konar added a comment - +1 the patch looks good.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          c6560_20100212_y0.20.patch: for y0.20

          Show
          Tsz Wo Nicholas Sze added a comment - c6560_20100212_y0.20.patch: for y0.20
          Hide
          Tsz Wo Nicholas Sze added a comment -

          I have committed this.

          Show
          Tsz Wo Nicholas Sze added a comment - I have committed this.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #172 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/172/)
          . Handle invalid har:// uri in HarFileSystem.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #172 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/172/ ) . Handle invalid har:// uri in HarFileSystem.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #252 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/252/)
          . Handle invalid har:// uri in HarFileSystem.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #252 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/252/ ) . Handle invalid har:// uri in HarFileSystem.

            People

            • Assignee:
              Tsz Wo Nicholas Sze
              Reporter:
              Tsz Wo Nicholas Sze
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development