Hadoop Common
  1. Hadoop Common
  2. HADOOP-6548

Replace org.mortbay.log.Log imports with commons logging

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: fs, io
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Some IDEs auto-import org.mortbay.log.Log, contrary to the standard pattern using commons logging.

      1. C6548-0.patch
        4 kB
        Chris Douglas

        Activity

        Chris Douglas created issue -
        Chris Douglas made changes -
        Field Original Value New Value
        Attachment C6548-0.patch [ 12435199 ]
        Chris Douglas made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Tsz Wo Nicholas Sze added a comment -

        +1 patch looks good.

        Show
        Tsz Wo Nicholas Sze added a comment - +1 patch looks good.
        Tsz Wo Nicholas Sze made changes -
        Hadoop Flags [Reviewed]
        Assignee Chris Douglas [ chris.douglas ]
        Component/s fs [ 12310689 ]
        Component/s io [ 12310687 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12435199/C6548-0.patch
        against trunk revision 907549.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/344/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/344/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/344/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/344/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12435199/C6548-0.patch against trunk revision 907549. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/344/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/344/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/344/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/344/console This message is automatically generated.
        Hide
        Steve Loughran added a comment -

        +1 on this. no need for tests

        Show
        Steve Loughran added a comment - +1 on this. no need for tests
        Hide
        Chris Douglas added a comment -

        I committed this.

        Show
        Chris Douglas added a comment - I committed this.
        Chris Douglas made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Fix Version/s 0.22.0 [ 12314296 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #166 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/166/)
        . Replace mortbay imports with commons logging.

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #166 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/166/ ) . Replace mortbay imports with commons logging.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #249 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/249/)
        . Replace mortbay imports with commons logging.

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #249 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/249/ ) . Replace mortbay imports with commons logging.
        Tom White made changes -
        Fix Version/s 0.21.0 [ 12313563 ]
        Fix Version/s 0.22.0 [ 12314296 ]
        Tom White made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        2m 2s 1 Chris Douglas 08/Feb/10 19:43
        Patch Available Patch Available Resolved Resolved
        4d 16h 37m 1 Chris Douglas 13/Feb/10 12:21
        Resolved Resolved Closed Closed
        192d 8h 20m 1 Tom White 24/Aug/10 21:41

          People

          • Assignee:
            Chris Douglas
            Reporter:
            Chris Douglas
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development