Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: build
    • Labels:
      None
    • Environment:

      ant 1.7.1
      Solaris

    • Hadoop Flags:
      Reviewed

      Description

      I'm not sure whether this is a Solaris thing or an ant 1.7.1 thing, but it definitely doesn't do what it is supposed to. Instead of getting SunOS-x86-32 (or whatever) I get -x86-32.

      This patch replaces the sed call with tr.

      1. HADOOP-6505.txt
        0.6 kB
        Allen Wittenauer

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #249 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/249/)
          . Use tr rather than sed to effect literal substitution in the
          build script. Contributed by Allen Wittenauer

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #249 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/249/ ) . Use tr rather than sed to effect literal substitution in the build script. Contributed by Allen Wittenauer
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #165 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/165/)
          . Use tr rather than sed to effect literal substitution in the
          build script. Contributed by Allen Wittenauer

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #165 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/165/ ) . Use tr rather than sed to effect literal substitution in the build script. Contributed by Allen Wittenauer
          Hide
          Chris Douglas added a comment -

          +1

          I committed this. Thanks, Allen!

          Show
          Chris Douglas added a comment - +1 I committed this. Thanks, Allen!
          Hide
          Steve Loughran added a comment -

          given that Hadoop is java1.6+ only, there is nothing to stop you using the <scriptdef> feature to implement the operation in the javascript engine built into the JVM, which eliminates all platform quirkyness

          Show
          Steve Loughran added a comment - given that Hadoop is java1.6+ only, there is nothing to stop you using the <scriptdef> feature to implement the operation in the javascript engine built into the JVM, which eliminates all platform quirkyness
          Hide
          Chad Metcalf added a comment -

          +1 Looks good to me.

          Show
          Chad Metcalf added a comment - +1 Looks good to me.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12431154/HADOOP-6505.txt
          against trunk revision 901924.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/286/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/286/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/286/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/286/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12431154/HADOOP-6505.txt against trunk revision 901924. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/286/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/286/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/286/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/286/console This message is automatically generated.
          Hide
          Allen Wittenauer added a comment -

          build.xml patch

          Show
          Allen Wittenauer added a comment - build.xml patch
          Hide
          Allen Wittenauer added a comment -

          wrong patch.

          Show
          Allen Wittenauer added a comment - wrong patch.

            People

            • Assignee:
              Allen Wittenauer
              Reporter:
              Allen Wittenauer
            • Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development