[HADOOP-6490] Path.normalize should use StringUtils.replace in favor of String.replace

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.20.1
• Fix Version/s: 0.23.1
• Component/s: fs
• Labels: newbie
• Hadoop Flags: Reviewed
• Tags: path
• Assignee: Uma Maheswara Rao G
• Reporter: Zheng Shao
• Created: 13/Jan/10 02:46
• Updated: 05/Mar/12 02:49
• Resolved: 12/Oct/11 03:20

Description

in our environment, we are seeing that the JobClient is going out of memory because Path.normalizePath(String) is called several tens of thousands of times, and each time it calls "String.replace" twice.

java.lang.String.replace compiles a regex to do the job which is very costly.
We should use org.apache.commons.lang.StringUtils.replace which is much faster and consumes almost no extra memory.