Hadoop Common
  1. Hadoop Common
  2. HADOOP-6435

Make RPC.waitForProxy with timeout public

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.21.0
    • Component/s: ipc
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The public RPC.waitForProxy() method waits for Long.MAX_VALUE before giving up, ignores all interrupt requests. This is excessive.

      The version of the method that is package scoped should be made public. Interrupt swallowing is covered in HADOOP-6221 and can be done as a separate patch

      1. HADOOP-6435-2.patch
        0.7 kB
        steve_l
      2. HADOOP-6435-1.patch
        0.7 kB
        steve_l

        Issue Links

          Activity

          Hide
          steve_l added a comment -

          This is the patch against HEAD. Created via git, which I am still coming to terms with, apologies if it does not work.

          the git patch is on github
          http://github.com/steveloughran/hadoop-common/commit/45cb88a660a3c1763e7cb07e4f845d9e3f042ae3

          Show
          steve_l added a comment - This is the patch against HEAD. Created via git, which I am still coming to terms with, apologies if it does not work. the git patch is on github http://github.com/steveloughran/hadoop-common/commit/45cb88a660a3c1763e7cb07e4f845d9e3f042ae3
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12428233/HADOOP-6435-1.patch
          against trunk revision 891132.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 patch. The patch command could not apply the patch.

          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/213/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12428233/HADOOP-6435-1.patch against trunk revision 891132. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/213/console This message is automatically generated.
          Hide
          steve_l added a comment -

          patch generated with the HEAD~1 and HEAD declarations in the correct order

          Show
          steve_l added a comment - patch generated with the HEAD~1 and HEAD declarations in the correct order
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12428437/HADOOP-6435-2.patch
          against trunk revision 892113.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/224/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/224/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/224/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/224/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12428437/HADOOP-6435-2.patch against trunk revision 892113. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/224/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/224/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/224/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/224/console This message is automatically generated.
          Hide
          Tom White added a comment -

          I've just committed this. Thanks Steve!

          Show
          Tom White added a comment - I've just committed this. Thanks Steve!
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #127 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/127/)
          . Make RPC.waitForProxy with timeout public. Contributed by Steve Loughran.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #127 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/127/ ) . Make RPC.waitForProxy with timeout public. Contributed by Steve Loughran.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #197 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/197/)
          . Make RPC.waitForProxy with timeout public. Contributed by Steve Loughran.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #197 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/197/ ) . Make RPC.waitForProxy with timeout public. Contributed by Steve Loughran.

            People

            • Assignee:
              Steve Loughran
              Reporter:
              Steve Loughran
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development