Hadoop Common
  1. Hadoop Common
  2. HADOOP-6396

Provide a description in the exception when an error is encountered parsing umask

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.21.0, 0.22.0
    • Fix Version/s: 0.21.0
    • Component/s: fs
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Currently when there is a problem parsing a umask, the exception text is just the offending umask with no other clue, which can be quite confusing as demonstrated in HDFS-763. This message should include the nature of the problem and whether or not the umask parsing attempt was using old-style or new-style values.

      1. HADOOP-6396-B.patch
        4 kB
        Jakob Homan
      2. HADOOP-6396.patch
        4 kB
        Jakob Homan

        Issue Links

          Activity

          Hide
          Jakob Homan added a comment -

          Linking to correct related issue, which is not 763.

          Show
          Jakob Homan added a comment - Linking to correct related issue, which is not 763.
          Hide
          Jakob Homan added a comment -

          Patch updates message and test case with more clear explanation of the issue. Tested against hdfs with new common jar and no problems.

          Show
          Jakob Homan added a comment - Patch updates message and test case with more clear explanation of the issue. Tested against hdfs with new common jar and no problems.
          Hide
          Jakob Homan added a comment -

          submitting patch.

          Show
          Jakob Homan added a comment - submitting patch.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12426184/HADOOP-6396.patch
          against trunk revision 883206.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/150/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/150/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/150/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/150/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12426184/HADOOP-6396.patch against trunk revision 883206. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/150/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/150/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/150/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/150/console This message is automatically generated.
          Hide
          Jakob Homan added a comment -

          Had uploaded wrong version of patch, this is correct. Since test-patch's testing is suspect at the moment, ran unit tests locally and all passed. Verified solution in hdfs.

          Show
          Jakob Homan added a comment - Had uploaded wrong version of patch, this is correct. Since test-patch's testing is suspect at the moment, ran unit tests locally and all passed. Verified solution in hdfs.
          Hide
          Jakob Homan added a comment -

          re-submitting patch.

          Show
          Jakob Homan added a comment - re-submitting patch.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12426534/HADOOP-6396-B.patch
          against trunk revision 885534.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/155/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/155/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/155/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/155/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12426534/HADOOP-6396-B.patch against trunk revision 885534. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/155/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/155/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/155/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/155/console This message is automatically generated.
          Hide
          Suresh Srinivas added a comment -

          +1 the patch looks good.

          Show
          Suresh Srinivas added a comment - +1 the patch looks good.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #99 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/99/)
          . Fix unhelpful exception message when unable to parse umask (jghoman)

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #99 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/99/ ) . Fix unhelpful exception message when unable to parse umask (jghoman)
          Hide
          Jakob Homan added a comment -

          I have committed this to trunk and 21. Closing issue.

          Show
          Jakob Homan added a comment - I have committed this to trunk and 21. Closing issue.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #178 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/178/)
          . Fix unhelpful exception message when unable to parse umask (jghoman)

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #178 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/178/ ) . Fix unhelpful exception message when unable to parse umask (jghoman)

            People

            • Assignee:
              Jakob Homan
              Reporter:
              Jakob Homan
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development