Hadoop Common
  1. Hadoop Common
  2. HADOOP-6385

dfs does not support -rmdir (was HDFS-639)

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23.0
    • Component/s: fs
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      The "rm" family of FsShell commands now supports -rmdir and -f options.

      Description

      From HDFS-639
      > Given we have a mkdir, we should have a rmdir. Using rmr is not
      > a reasonable substitute when you only want to delete empty
      > directories.

      1. HADOOP-6385-3.patch
        7 kB
        Daryn Sharp
      2. HADOOP-6385-2.patch
        7 kB
        Daryn Sharp
      3. HADOOP-6385-2.patch
        7 kB
        Daryn Sharp
      4. HADOOP-6385.patch
        10 kB
        Scott Phillips

        Issue Links

          Activity

          Hide
          Scott Phillips added a comment -

          [exec] +1 overall.
          [exec]
          [exec] +1 @author. The patch does not contain any @author tags.
          [exec]
          [exec] +1 tests included. The patch appears to include 3 new or modified tests.
          [exec]
          [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
          [exec]
          [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
          [exec]
          [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
          [exec]
          [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
          [exec]

          Show
          Scott Phillips added a comment - [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec]
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12425890/HADOOP-6385.patch
          against trunk revision 883206.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/145/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/145/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/145/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/145/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12425890/HADOOP-6385.patch against trunk revision 883206. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/145/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/145/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/145/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/145/console This message is automatically generated.
          Hide
          Jakob Homan added a comment -

          Hey Scott, re-opening as resolved is used for issues that have been committed, which this hasn't. Were you still wanting this feature? I personally have some concerns about it, but haven't had a chance to look at the patch or comment.

          Show
          Jakob Homan added a comment - Hey Scott, re-opening as resolved is used for issues that have been committed, which this hasn't. Were you still wanting this feature? I personally have some concerns about it, but haven't had a chance to look at the patch or comment.
          Hide
          Scott Phillips added a comment -

          Ya, sorry Jakob, I was unclear on the process. Let me know what concerns you have if you get a chance to look at the patch. Thanks.

          Show
          Scott Phillips added a comment - Ya, sorry Jakob, I was unclear on the process. Let me know what concerns you have if you get a chance to look at the patch. Thanks.
          Hide
          Daryn Sharp added a comment -

          Requested by pig project

          Show
          Daryn Sharp added a comment - Requested by pig project
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12481525/HADOOP-6385-2.patch
          against trunk revision 1131330.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/579//testReport/
          Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/579//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/579//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12481525/HADOOP-6385-2.patch against trunk revision 1131330. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/579//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/579//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/579//console This message is automatically generated.
          Hide
          Matt Foley added a comment -

          Would give this a +1, but it needs to be re-based. Please up-rev to current trunk and I'll commit.

          Show
          Matt Foley added a comment - Would give this a +1, but it needs to be re-based. Please up-rev to current trunk and I'll commit.
          Hide
          Daryn Sharp added a comment -

          resolve minor merge conflict

          Show
          Daryn Sharp added a comment - resolve minor merge conflict
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12487705/HADOOP-6385-3.patch
          against trunk revision 1150565.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/763//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/763//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/763//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12487705/HADOOP-6385-3.patch against trunk revision 1150565. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/763//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/763//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/763//console This message is automatically generated.
          Hide
          Matt Foley added a comment -

          Committed to trunk. Thanks, Daryn!

          Show
          Matt Foley added a comment - Committed to trunk. Thanks, Daryn!
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #700 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/700/)
          HADOOP-6385. dfs should support -rmdir (was HDFS-639). Contributed by Daryn Sharp.

          mattf : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1150987
          Files :

          • /hadoop/common/trunk/common/src/test/core/org/apache/hadoop/cli/testConf.xml
          • /hadoop/common/trunk/common/CHANGES.txt
          • /hadoop/common/trunk/common/src/java/org/apache/hadoop/fs/shell/Delete.java
          • /hadoop/common/trunk/common/src/java/org/apache/hadoop/fs/shell/PathExceptions.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #700 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/700/ ) HADOOP-6385 . dfs should support -rmdir (was HDFS-639 ). Contributed by Daryn Sharp. mattf : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1150987 Files : /hadoop/common/trunk/common/src/test/core/org/apache/hadoop/cli/testConf.xml /hadoop/common/trunk/common/CHANGES.txt /hadoop/common/trunk/common/src/java/org/apache/hadoop/fs/shell/Delete.java /hadoop/common/trunk/common/src/java/org/apache/hadoop/fs/shell/PathExceptions.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #758 (See https://builds.apache.org/job/Hadoop-Common-trunk/758/)
          HADOOP-6385. dfs should support -rmdir (was HDFS-639). Contributed by Daryn Sharp.

          mattf : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1150987
          Files :

          • /hadoop/common/trunk/common/src/test/core/org/apache/hadoop/cli/testConf.xml
          • /hadoop/common/trunk/common/CHANGES.txt
          • /hadoop/common/trunk/common/src/java/org/apache/hadoop/fs/shell/Delete.java
          • /hadoop/common/trunk/common/src/java/org/apache/hadoop/fs/shell/PathExceptions.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #758 (See https://builds.apache.org/job/Hadoop-Common-trunk/758/ ) HADOOP-6385 . dfs should support -rmdir (was HDFS-639 ). Contributed by Daryn Sharp. mattf : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1150987 Files : /hadoop/common/trunk/common/src/test/core/org/apache/hadoop/cli/testConf.xml /hadoop/common/trunk/common/CHANGES.txt /hadoop/common/trunk/common/src/java/org/apache/hadoop/fs/shell/Delete.java /hadoop/common/trunk/common/src/java/org/apache/hadoop/fs/shell/PathExceptions.java

            People

            • Assignee:
              Daryn Sharp
              Reporter:
              Scott Phillips
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development