Hadoop Common
  1. Hadoop Common
  2. HADOOP-6374

JUnit tests should never depend on anything in conf

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.21.0, 0.22.0
    • Fix Version/s: 0.21.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The recent change to mapred-queues.xml that causes many mapreduce tests to break unless you delete conf/mapred-queues.xml out of your build tree is bad. We need to make sure that nothing in conf is used in the unit tests. One potential solution is to copy the templates into build/test/conf and use that instead.

      1. HADOOP-6374.patch
        1 kB
        Anatoli Fomenko

        Issue Links

          Activity

          Owen O'Malley created issue -
          Anatoli Fomenko made changes -
          Field Original Value New Value
          Assignee Anatoli Fomenko [ anatoli.fomenko ]
          Anatoli Fomenko made changes -
          Link This issue is blocked by MAPREDUCE-1369 [ MAPREDUCE-1369 ]
          Anatoli Fomenko made changes -
          Link This issue is related to MAPREDUCE-1369 [ MAPREDUCE-1369 ]
          Anatoli Fomenko made changes -
          Link This issue is blocked by MAPREDUCE-1369 [ MAPREDUCE-1369 ]
          Hide
          Anatoli Fomenko added a comment -

          Similar issue has been created for Map/Reduce (MAPREDUCE-1369, see Issue Links). Perhaps, a similar issue should be also created for HDFS.

          Show
          Anatoli Fomenko added a comment - Similar issue has been created for Map/Reduce ( MAPREDUCE-1369 , see Issue Links). Perhaps, a similar issue should be also created for HDFS.
          Anatoli Fomenko made changes -
          Attachment HADOOP-6374.patch [ 12429870 ]
          Hide
          Anatoli Fomenko added a comment -

          Please review the submitted patch.

          The patch is the same as in MAPREDUCE-1369, attached at 2010-01-11 04:04 AM (with different line numbers), and details are the same as described in the comment to MAPREDUCE-1369 added at 11/Jan/10 04:12 AM.

          Show
          Anatoli Fomenko added a comment - Please review the submitted patch. The patch is the same as in MAPREDUCE-1369 , attached at 2010-01-11 04:04 AM (with different line numbers), and details are the same as described in the comment to MAPREDUCE-1369 added at 11/Jan/10 04:12 AM.
          Anatoli Fomenko made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12429870/HADOOP-6374.patch
          against trunk revision 897023.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/268/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/268/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/268/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/268/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12429870/HADOOP-6374.patch against trunk revision 897023. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/268/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/268/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/268/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/268/console This message is automatically generated.
          Hide
          Anatoli Fomenko added a comment -

          Please review the submitted patch. Thanks.

          Show
          Anatoli Fomenko added a comment - Please review the submitted patch. Thanks.
          Hide
          Anatoli Fomenko added a comment -

          Please review the submitted patch. Thanks.

          Show
          Anatoli Fomenko added a comment - Please review the submitted patch. Thanks.
          Hide
          Anatoli Fomenko added a comment -

          Please review the submitted patch. Thanks.

          Show
          Anatoli Fomenko added a comment - Please review the submitted patch. Thanks.
          Hide
          Konstantin Boudnik added a comment -

          +1 patch looks good. I see that a similar JIRA has been open for MapReduce. I think the same needs to be done for HDFS subproject.

          I also have ran all Common's tests and they seem to be just fine with the patch in place. I'm going to commit it.

          Show
          Konstantin Boudnik added a comment - +1 patch looks good. I see that a similar JIRA has been open for MapReduce. I think the same needs to be done for HDFS subproject. I also have ran all Common's tests and they seem to be just fine with the patch in place. I'm going to commit it.
          Hide
          Konstantin Boudnik added a comment -

          I've just committed this to the trunk. Thanks Anatoli!

          Show
          Konstantin Boudnik added a comment - I've just committed this to the trunk. Thanks Anatoli!
          Konstantin Boudnik made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags [Reviewed]
          Fix Version/s 0.22.0 [ 12314296 ]
          Resolution Fixed [ 1 ]
          Konstantin Boudnik made changes -
          Fix Version/s 0.21.0 [ 12313563 ]
          Affects Version/s 0.21.0 [ 12313563 ]
          Affects Version/s 0.22.0 [ 12314296 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #229 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/229/)

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #229 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/229/ )
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #147 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/147/)

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #147 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/147/ )
          Amareshwari Sriramadasu made changes -
          Link This issue incorporates HADOOP-6348 [ HADOOP-6348 ]
          Konstantin Boudnik made changes -
          Link This issue is cloned as HADOOP-6587 [ HADOOP-6587 ]
          Tom White made changes -
          Fix Version/s 0.22.0 [ 12314296 ]
          Tom White made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          58d 5h 59m 1 Anatoli Fomenko 11/Jan/10 06:29
          Patch Available Patch Available Resolved Resolved
          9d 23h 29m 1 Konstantin Boudnik 21/Jan/10 05:58
          Resolved Resolved Closed Closed
          215d 14h 42m 1 Tom White 24/Aug/10 21:40

            People

            • Assignee:
              Anatoli Fomenko
              Reporter:
              Owen O'Malley
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development