Hadoop Common
  1. Hadoop Common
  2. HADOOP-6367

Move Access Token implementation from Common to HDFS

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: security
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change

      Description

      Access Token is HDFS specific and should be part of HDFS code base. Also, rename AccessToken to BlockAccessToken (and AccessKey to BlockAccessKey) to be more precise.

      1. c6367-03.patch
        33 kB
        Kan Zhang
      2. c6367-03.patch
        33 kB
        Kan Zhang
      3. HADOOP-6367_HDFS-764-0_20.1.patch
        92 kB
        Jitendra Nath Pandey

        Issue Links

          Activity

          Hide
          Allen Wittenauer added a comment -

          Really? Does this mean there is no security if I run the JobTracker and TaskTracker on a non-HDFS based file system?

          Show
          Allen Wittenauer added a comment - Really? Does this mean there is no security if I run the JobTracker and TaskTracker on a non-HDFS based file system?
          Hide
          Kan Zhang added a comment -

          > Does this mean there is no security if I run the JobTracker and TaskTracker on a non-HDFS based file system?
          That depends on whether that non-HDFS based file system enforces any access control. It's unrelated to how HDFS does its access control. Access Token is a feature of HDFS and currently I don't see how other file systems could make use of it.

          Show
          Kan Zhang added a comment - > Does this mean there is no security if I run the JobTracker and TaskTracker on a non-HDFS based file system? That depends on whether that non-HDFS based file system enforces any access control. It's unrelated to how HDFS does its access control. Access Token is a feature of HDFS and currently I don't see how other file systems could make use of it.
          Hide
          Kan Zhang added a comment -

          attaching a patch for the changes in common (7 files removed). No new test is added since there is no functional change (only moving code around and renaming).

          Show
          Kan Zhang added a comment - attaching a patch for the changes in common (7 files removed). No new test is added since there is no functional change (only moving code around and renaming).
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12424647/c6367-03.patch
          against trunk revision 833553.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/133/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/133/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/133/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/133/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12424647/c6367-03.patch against trunk revision 833553. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/133/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/133/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/133/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/133/console This message is automatically generated.
          Hide
          Jitendra Nath Pandey added a comment -

          +1 for the patch.

          Show
          Jitendra Nath Pandey added a comment - +1 for the patch.
          Hide
          Kan Zhang added a comment -

          Attaching the same patch again. The first one didn't grant the license when attaching.

          Show
          Kan Zhang added a comment - Attaching the same patch again. The first one didn't grant the license when attaching.
          Hide
          Devaraj Das added a comment -

          I just committed this. Thanks, Kan!

          Show
          Devaraj Das added a comment - I just committed this. Thanks, Kan!
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #162 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/162/)
          . Removes Access Token implementation from common. Contributed by Kan Zhang.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #162 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/162/ ) . Removes Access Token implementation from common. Contributed by Kan Zhang.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #91 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/91/)
          . Removes Access Token implementation from common. Contributed by Kan Zhang.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #91 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/91/ ) . Removes Access Token implementation from common. Contributed by Kan Zhang.
          Hide
          Jitendra Nath Pandey added a comment -

          Patch for hadoop 20 is added. This is a combined patch for HADOOP-6367 and HDFS-764. A combined patch or hadoop 20 is required otherwise build will fail.

          Show
          Jitendra Nath Pandey added a comment - Patch for hadoop 20 is added. This is a combined patch for HADOOP-6367 and HDFS-764 . A combined patch or hadoop 20 is required otherwise build will fail.

            People

            • Assignee:
              Kan Zhang
              Reporter:
              Kan Zhang
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development