Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: io, ipc
    • Labels:
      None

      Description

      Avro 1.2 has been released. The API's Hadoop Common uses have been simplified, and it should be upgraded.

      1. HADOOP-6318.java
        4 kB
        Doug Cutting
      2. HADOOP-6318.patch
        5 kB
        Doug Cutting

        Activity

        Hide
        Doug Cutting added a comment -

        Here's a patch that upgrades Hadoop Common to use Avro 1.2.0.

        Show
        Doug Cutting added a comment - Here's a patch that upgrades Hadoop Common to use Avro 1.2.0.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12422404/HADOOP-6318.java
        against trunk revision 824942.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/18/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/18/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/18/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/18/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12422404/HADOOP-6318.java against trunk revision 824942. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/18/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/18/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/18/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/18/console This message is automatically generated.
        Hide
        Philip Zeyliger added a comment -

        Could you also update the Eclipse classpath

        $cat .eclipse.templates/.classpath  | grep avro
        	<classpathentry kind="lib" path="build/ivy/lib/Hadoop-Core/common/avro-1.1.0.jar"/>
        

        when you commit this?

        Thanks!

        Show
        Philip Zeyliger added a comment - Could you also update the Eclipse classpath $cat .eclipse.templates/.classpath | grep avro <classpathentry kind="lib" path="build/ivy/lib/Hadoop-Core/common/avro-1.1.0.jar"/> when you commit this? Thanks!
        Hide
        Konstantin Boudnik added a comment -

        .bq Could you also update the Eclipse classpath
        It'd be great to do so across all dependent projects such as MapReduce as well.

        Show
        Konstantin Boudnik added a comment - .bq Could you also update the Eclipse classpath It'd be great to do so across all dependent projects such as MapReduce as well.
        Hide
        Doug Cutting added a comment -

        > Could you also update the Eclipse classpath [ ... ]

        Done. However I am not an Eclipse user and will be unable to test this. It also seems very unfortunate that this file is not automatically generated, but that should be the subject of a different issue.

        Show
        Doug Cutting added a comment - > Could you also update the Eclipse classpath [ ... ] Done. However I am not an Eclipse user and will be unable to test this. It also seems very unfortunate that this file is not automatically generated, but that should be the subject of a different issue.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12422954/HADOOP-6318.patch
        against trunk revision 828181.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/102/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/102/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/102/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/102/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12422954/HADOOP-6318.patch against trunk revision 828181. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/102/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/102/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/102/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/102/console This message is automatically generated.
        Hide
        Sharad Agarwal added a comment -

        +1 Patch looks good. Eclipse classpath changes worked fine. minor nit: noticed a redundant import org.apache.avro.* in AvroRPC

        Show
        Sharad Agarwal added a comment - +1 Patch looks good. Eclipse classpath changes worked fine. minor nit: noticed a redundant import org.apache.avro.* in AvroRPC
        Hide
        Doug Cutting added a comment -

        I just committed this.

        Should I apply this to the 0.21 branch, to keep things in sync with MAPREDUCE-1016?

        Show
        Doug Cutting added a comment - I just committed this. Should I apply this to the 0.21 branch, to keep things in sync with MAPREDUCE-1016 ?
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #71 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/71/)
        . Upgrade to Avro 1.2.0.

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #71 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/71/ ) . Upgrade to Avro 1.2.0.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #72 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/72/)
        . Move CHANGES.txt message to 0.21 section.

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #72 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/72/ ) . Move CHANGES.txt message to 0.21 section.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #137 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/137/)
        . Move CHANGES.txt message to 0.21 section.
        . Upgrade to Avro 1.2.0.

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #137 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/137/ ) . Move CHANGES.txt message to 0.21 section. . Upgrade to Avro 1.2.0.
        Hide
        Vinod Kumar Vavilapalli added a comment -

        What about mapreduce? Do we need it right away? Any tracking issue that is already filed?

        Show
        Vinod Kumar Vavilapalli added a comment - What about mapreduce? Do we need it right away? Any tracking issue that is already filed?
        Hide
        Doug Cutting added a comment -

        > What about mapreduce?

        I snuck this into MAPREDUCE-1016, so it's also been upgraded to Avro 1.2.0.

        Show
        Doug Cutting added a comment - > What about mapreduce? I snuck this into MAPREDUCE-1016 , so it's also been upgraded to Avro 1.2.0.

          People

          • Assignee:
            Doug Cutting
            Reporter:
            Doug Cutting
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development