Hadoop Common
  1. Hadoop Common
  2. HADOOP-6285

HttpServer.QuotingInputFilter has the wrong signature for getParameterMap

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In the HDFS tests, we see:

      java.lang.ClassCastException: [Ljava.lang.String; cannot be cast to java.lang.String
      	at org.apache.hadoop.http.HttpServer$QuotingInputFilter$RequestQuoter.getParameterMap(HttpServer.java:591)
      	at org.apache.hadoop.hdfs.server.namenode.FsckServlet.doGet(FsckServlet.java:44)
      	at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
      	at javax.servlet.http.HttpServlet.service(HttpServlet.java:820)
      	at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:502)
      	at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1124)
      	at org.apache.hadoop.http.HttpServer$QuotingInputFilter.doFilter(HttpServer.java:613)
      	at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1115)
      	at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:361)
      	at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216)
      	at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:181)
      	at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:766)
      	at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:417)
      	at org.mortbay.jetty.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:230)
      	at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152)
      	at org.mortbay.jetty.Server.handle(Server.java:324)
      	at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:534)
      	at org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnection.java:864)
      	at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:533)
      	at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:207)
      	at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:403)
      	at org.mortbay.io.nio.SelectChannelEndPoint.run(SelectChannelEndPoint.java:409)
      	at org.mortbay.thread.QueuedThreadPool$PoolThread.run(QueuedThreadPool.java:522)
      
      1. h-6285.path
        6 kB
        Owen O'Malley
      2. h-6285.patch
        6 kB
        Owen O'Malley
      3. h-6285.20.patch
        6 kB
        Devaraj Das

        Issue Links

          Activity

          Hide
          Owen O'Malley added a comment -

          This patch fixes the signature of getParameterMap and adds testcases of HttpServer.

          Show
          Owen O'Malley added a comment - This patch fixes the signature of getParameterMap and adds testcases of HttpServer.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12420575/h-6285.path
          against trunk revision 818543.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 2 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/64/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/64/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/64/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/64/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12420575/h-6285.path against trunk revision 818543. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/64/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/64/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/64/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/64/console This message is automatically generated.
          Hide
          Owen O'Malley added a comment -

          The new test needs to create build/webapps/test. sigh

          Show
          Owen O'Malley added a comment - The new test needs to create build/webapps/test. sigh
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12420588/h-6285.patch
          against trunk revision 818543.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/65/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/65/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/65/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/65/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12420588/h-6285.patch against trunk revision 818543. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/65/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/65/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/65/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/65/console This message is automatically generated.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          +1 patch looks good.

          Show
          Tsz Wo Nicholas Sze added a comment - +1 patch looks good.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #52 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/52/)
          . Fix the result type of the getParameterMap method in the
          HttpServer.QuotingInputFilter. (omalley)

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #52 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/52/ ) . Fix the result type of the getParameterMap method in the HttpServer.QuotingInputFilter. (omalley)
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #68 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/68/)
          . Fix the return type from
          HttpServer.QuoteInputFilter.getParameterMap.

          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #68 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/68/ ) . Fix the return type from HttpServer.QuoteInputFilter.getParameterMap.
          Hide
          Owen O'Malley added a comment -

          I just committed this.

          Show
          Owen O'Malley added a comment - I just committed this.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #57 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/57/)
          . Fix return type on HttpServer.QuoteInputFilter.getParameterMap.

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #57 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/57/ ) . Fix return type on HttpServer.QuoteInputFilter.getParameterMap.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #98 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/98/)
          . Fix return type on HttpServer.QuoteInputFilter.getParameterMap.

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #98 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/98/ ) . Fix return type on HttpServer.QuoteInputFilter.getParameterMap.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #112 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/112/)
          . Fix the result type of the getParameterMap method in the
          HttpServer.QuotingInputFilter. (omalley)

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #112 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/112/ ) . Fix the result type of the getParameterMap method in the HttpServer.QuotingInputFilter. (omalley)
          Hide
          Hudson added a comment -

          Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #20 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/20/)

          Show
          Hudson added a comment - Integrated in Hdfs-Patch-h2.grid.sp2.yahoo.net #20 (See http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/20/ )
          Hide
          Devaraj Das added a comment -

          This patch applies to 0.20. (not to be committed)

          Show
          Devaraj Das added a comment - This patch applies to 0.20. (not to be committed)

            People

            • Assignee:
              Owen O'Malley
              Reporter:
              Owen O'Malley
            • Votes:
              1 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development