Hadoop Common
  1. Hadoop Common
  2. HADOOP-6267

build-contrib.xml unnecessarily enforces that contrib projects be located in contrib/ dir

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: build
    • Labels:
      None

      Description

      build-contrib.xml currently sets hadoop.root to $

      {basedir}

      /../../../. This path is relative to the contrib project which is assumed to be inside src/contrib/. We occasionally work on contrib projects in other repositories until they're ready to contribute. We can use the <dirname> ant task to do this more correctly.

        Activity

        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12419939/hadoop-6267.txt
        against trunk revision 816398.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/43/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/43/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/43/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/43/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12419939/hadoop-6267.txt against trunk revision 816398. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/43/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/43/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/43/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/43/console This message is automatically generated.
        Hide
        Chris Douglas added a comment -

        This isn't an Apache build issue.

        Show
        Chris Douglas added a comment - This isn't an Apache build issue.
        Hide
        Todd Lipcon added a comment -

        I disagree. This is simply better ant style, and the technique is a specific example on the ant import task documentation:

        http://ant.apache.org/manual/CoreTasks/import.html

        Part of the ASF principles and the choice of the Apache license is to encourage outside contributions. While this has no positive (or negative) effect on the project build itself, it makes it easier to develop code that will later be contributed, and encourages that development to be tightly coupled to the existing build process. This means there will be less work later to add it as a contrib/ project, which is good for everyone involved.

        Do you have any specific complaints about the patch? If it is zero-sum for the existing codebase but positive for future contributions, it seems to me like it's a net win.

        Show
        Todd Lipcon added a comment - I disagree. This is simply better ant style, and the technique is a specific example on the ant import task documentation: http://ant.apache.org/manual/CoreTasks/import.html Part of the ASF principles and the choice of the Apache license is to encourage outside contributions. While this has no positive (or negative) effect on the project build itself, it makes it easier to develop code that will later be contributed, and encourages that development to be tightly coupled to the existing build process. This means there will be less work later to add it as a contrib/ project, which is good for everyone involved. Do you have any specific complaints about the patch? If it is zero-sum for the existing codebase but positive for future contributions, it seems to me like it's a net win.
        Hide
        Doug Cutting added a comment -

        +1 This seems reasonable to me.

        Chris, are you vetoing this, or can I commit it?

        Show
        Doug Cutting added a comment - +1 This seems reasonable to me. Chris, are you vetoing this, or can I commit it?
        Hide
        Chris Douglas added a comment -

        No, I'm not vetoing it. It doesn't seem useful, but neither is it harmful. If it helps, then sure

        Show
        Chris Douglas added a comment - No, I'm not vetoing it. It doesn't seem useful, but neither is it harmful. If it helps, then sure
        Hide
        Doug Cutting added a comment -

        I just committed this. Thanks, Todd!

        Show
        Doug Cutting added a comment - I just committed this. Thanks, Todd!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #102 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/102/)
        . Permit building contrib modules located in external source trees. Contributed by Todd Lipcon.

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #102 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/102/ ) . Permit building contrib modules located in external source trees. Contributed by Todd Lipcon.

          People

          • Assignee:
            Todd Lipcon
            Reporter:
            Todd Lipcon
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development