Hadoop Common
  1. Hadoop Common
  2. HADOOP-6252

Provide method to determine if a deprecated key was set in the config file

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.21.0
    • Fix Version/s: 0.21.0
    • Component/s: conf
    • Labels:
      None

      Description

      HADOOP-6105 provided a method to deprecate config keys and transparently refer to the new key. However, it didn't provide a method to see if the deprecated key had been used in the config file. This is useful when, if the deprecated key had been used, its value needs to be converted before use, for instance when we changed the umask format. A method like "boolean wasDeprecatedKeySet()" would be great. Patch shortly.

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #92 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/92/)
          . Provide a method to determine if a deprecated key is set in config file. Contributed by Jakob Homan.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #92 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/92/ ) . Provide a method to determine if a deprecated key is set in config file. Contributed by Jakob Homan.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #26 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/26/)
          . Provide a method to determine if a deprecated key is set in config file. Contributed by Jakob Homan.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #26 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/26/ ) . Provide a method to determine if a deprecated key is set in config file. Contributed by Jakob Homan.
          Hide
          Suresh Srinivas added a comment -

          Committed the change. Thank you Jakob.

          Show
          Suresh Srinivas added a comment - Committed the change. Thank you Jakob.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12419227/HADOOP-6252.patch
          against trunk revision 813581.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/28/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/28/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/28/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/28/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12419227/HADOOP-6252.patch against trunk revision 813581. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/28/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/28/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/28/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/28/console This message is automatically generated.
          Hide
          Suresh Srinivas added a comment -

          +1

          Show
          Suresh Srinivas added a comment - +1
          Hide
          Jakob Homan added a comment -

          submitting patch

          Show
          Jakob Homan added a comment - submitting patch
          Hide
          Jakob Homan added a comment -

          Patch:

          • Implements new method to see if deprecated key had been used in config file
          • Provides test for this functionality
          • Removes unnecessary import
          Show
          Jakob Homan added a comment - Patch: Implements new method to see if deprecated key had been used in config file Provides test for this functionality Removes unnecessary import

            People

            • Assignee:
              Jakob Homan
              Reporter:
              Jakob Homan
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development