Hadoop Common
  1. Hadoop Common
  2. HADOOP-6246

Update umask code to use key deprecation facilities from HADOOP-6105

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: fs
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      When the new octal/symbolic umask JIRA (HADOOP-6234) went through, the config key deprecation patch (HADOOP-6105) wasn't ready. Now that both are committed, the home-brewed key deprecation system from 6234 should be updated to use the new system.

        Issue Links

          Activity

          Hide
          Jakob Homan added a comment -

          Patch to use Configuration's Deprecation facilities and a test that old-style decimal values are correctly converted over.

          Show
          Jakob Homan added a comment - Patch to use Configuration's Deprecation facilities and a test that old-style decimal values are correctly converted over.
          Hide
          Jakob Homan added a comment -

          submitting patch

          Show
          Jakob Homan added a comment - submitting patch
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12419250/HADOOP-6246.patch
          against trunk revision 813639.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/29/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/29/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/29/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/29/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12419250/HADOOP-6246.patch against trunk revision 813639. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/29/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/29/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/29/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/29/console This message is automatically generated.
          Hide
          Jitendra Nath Pandey added a comment -

          +1 for the patch.

          Show
          Jitendra Nath Pandey added a comment - +1 for the patch.
          Hide
          Suresh Srinivas added a comment -

          Committed the change. Thank you Jakob.

          Show
          Suresh Srinivas added a comment - Committed the change. Thank you Jakob.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #28 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/28/)
          . Add backward compatibility support to use deprecated decimal umask from old configuration. Contributed by Jakob Homan.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #28 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/28/ ) . Add backward compatibility support to use deprecated decimal umask from old configuration. Contributed by Jakob Homan.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #93 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/93/)
          . Add backward compatibility support to use deprecated decimal umask from old configuration. Contributed by Jakob Homan.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #93 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/93/ ) . Add backward compatibility support to use deprecated decimal umask from old configuration. Contributed by Jakob Homan.

            People

            • Assignee:
              Jakob Homan
              Reporter:
              Jakob Homan
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development