Hadoop Common
  1. Hadoop Common
  2. HADOOP-6197

Use aspects to introduce new methods required for testing

    Details

    • Type: Test Test
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 0.22.0
    • Fix Version/s: None
    • Component/s: security, test
    • Labels:
      None

      Description

      HADOOP-6176 introduces two new methods which are essentially required for testing purposes. However, this bring a permanent modifications to the production code.

      The same result can be reached by using aspect development. Thus the modifications will be brought in by byte code instrumentation and will exist only during the testing cycles.

      1. HADOOP-6197.patch
        3 kB
        Konstantin Boudnik
      2. HADOOP-6197.patch
        3 kB
        Konstantin Boudnik
      3. HADOOP-6197.patch
        3 kB
        Konstantin Boudnik
      4. HADOOP-6197.sh
        0.1 kB
        Konstantin Boudnik

        Issue Links

          Activity

          Hide
          Konstantin Boudnik added a comment -

          These two files show the essence of needed modifications. New aspect will instrument AccessTokenHandler class with two required methods. Thus, these aren't needed any longer in the source code of AccessTokenHandler.

          At this time, the patch can't be applied because Common project doesn't use the fault injection framework introduced for HDFS (see HDFS-435). However, as soon as the framework will be ported over to the Common, we'll be able to use this very method of code instrumentation.

          Also, the patch might require some extra fine tuning like moving some tests from a 'normal' test list into 'fault-injected' test list.

          Show
          Konstantin Boudnik added a comment - These two files show the essence of needed modifications. New aspect will instrument AccessTokenHandler class with two required methods. Thus, these aren't needed any longer in the source code of AccessTokenHandler . At this time, the patch can't be applied because Common project doesn't use the fault injection framework introduced for HDFS (see HDFS-435 ). However, as soon as the framework will be ported over to the Common, we'll be able to use this very method of code instrumentation. Also, the patch might require some extra fine tuning like moving some tests from a 'normal' test list into 'fault-injected' test list.
          Hide
          Vinod Kumar Vavilapalli added a comment -

          However, as soon as the framework will be ported over to the Common, we'll be able to use this very method of code instrumentation.

          Is there any JIRA issue already opened for this?

          Show
          Vinod Kumar Vavilapalli added a comment - However, as soon as the framework will be ported over to the Common, we'll be able to use this very method of code instrumentation. Is there any JIRA issue already opened for this?
          Hide
          Konstantin Boudnik added a comment -

          Not yet. I'll link this JIRA as soon as I'll have a new one for fault injection
          framework's porting.

          Show
          Konstantin Boudnik added a comment - Not yet. I'll link this JIRA as soon as I'll have a new one for fault injection framework's porting.
          Hide
          Konstantin Boudnik added a comment -

          As fault injection framework is being ported to the Common I have a chance to actually verify the suggested patch and find some issues with it.

          Fixed now.

          Show
          Konstantin Boudnik added a comment - As fault injection framework is being ported to the Common I have a chance to actually verify the suggested patch and find some issues with it. Fixed now.
          Hide
          Konstantin Boudnik added a comment -

          Although there's no tests to use this new injected API it seems that everything is in place and ready for commit.

          Show
          Konstantin Boudnik added a comment - Although there's no tests to use this new injected API it seems that everything is in place and ready for commit.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12418842/HADOOP-6197.patch
          against trunk revision 835967.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/137/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12418842/HADOOP-6197.patch against trunk revision 835967. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/137/console This message is automatically generated.
          Hide
          Konstantin Boudnik added a comment -

          Synch'ed up with trunk

          Show
          Konstantin Boudnik added a comment - Synch'ed up with trunk

            People

            • Assignee:
              Konstantin Boudnik
              Reporter:
              Konstantin Boudnik
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:

                Development