Hadoop Common
  1. Hadoop Common
  2. HADOOP-6160

releaseaudit (rats) should not be run againt the entire release binary

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: build
    • Labels:
      None
    1. HADOOP-6160.patch
      3 kB
      Giridharan Kesavan

      Activity

      Hide
      Giridharan Kesavan added a comment -

      use the rat anttask to configure rats to run against the specific directory.

      I'm thinking of excluding the following dirs/files for releaseaudit.

      build/hadoop-core-0.21.0-dev/CHANGES.txt
      build/hadoop-core-0.21.0-dev/docs
      build/hadoop-core-0.21.0-dev/lib/jdiff

      Show
      Giridharan Kesavan added a comment - use the rat anttask to configure rats to run against the specific directory. I'm thinking of excluding the following dirs/files for releaseaudit. build/hadoop-core-0.21.0-dev/CHANGES.txt build/hadoop-core-0.21.0-dev/docs build/hadoop-core-0.21.0-dev/lib/jdiff
      Hide
      Giridharan Kesavan added a comment -

      This patch is applicable for common, hdfs and mapred.

      Show
      Giridharan Kesavan added a comment - This patch is applicable for common, hdfs and mapred.
      Hide
      Giridharan Kesavan added a comment -

      can someone review this please?

      Show
      Giridharan Kesavan added a comment - can someone review this please?
      Hide
      Ramya Sunil added a comment -

      +1. Patch looks fine.

      Show
      Ramya Sunil added a comment - +1. Patch looks fine.
      Hide
      Giridharan Kesavan added a comment -

      this patch runs rats-ant task the release binary excluding docs and lib/jdiff dirs.
      Will file follow up jiras to add AL headers for files missing them and hence we can reduce the releaseaudit warnings count to zero.

      Show
      Giridharan Kesavan added a comment - this patch runs rats-ant task the release binary excluding docs and lib/jdiff dirs. Will file follow up jiras to add AL headers for files missing them and hence we can reduce the releaseaudit warnings count to zero.
      Hide
      Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12414427/HADOOP-6160.patch
      against trunk revision 797300.

      +1 @author. The patch does not contain any @author tags.

      -1 tests included. The patch doesn't appear to include any new or modified tests.
      Please justify why no new tests are needed for this patch.
      Also please list what manual steps were performed to verify this patch.

      +1 javadoc. The javadoc tool did not generate any warning messages.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 findbugs. The patch does not introduce any new Findbugs warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 core tests. The patch passed core unit tests.

      +1 contrib tests. The patch passed contrib unit tests.

      Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/584/testReport/
      Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/584/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
      Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/584/artifact/trunk/build/test/checkstyle-errors.html
      Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/584/console

      This message is automatically generated.

      Show
      Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12414427/HADOOP-6160.patch against trunk revision 797300. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/584/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/584/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/584/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/584/console This message is automatically generated.
      Hide
      Giridharan Kesavan added a comment -

      this patch doesn't requires a test as this just changes to the build.xml file.

      I just committed this!

      Show
      Giridharan Kesavan added a comment - this patch doesn't requires a test as this just changes to the build.xml file. I just committed this!
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Common-trunk #36 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/36/)
      . Fix ant releaseaudit target to run on specific directories. (Contributed by Giridharan Kesavan)

      Show
      Hudson added a comment - Integrated in Hadoop-Common-trunk #36 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/36/ ) . Fix ant releaseaudit target to run on specific directories. (Contributed by Giridharan Kesavan)
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Hdfs-trunk #31 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/31/)
      . Fix ant releaseaudit target to run on specific directories. (Contributed by Giridharan Kesavan)

      Show
      Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #31 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/31/ ) . Fix ant releaseaudit target to run on specific directories. (Contributed by Giridharan Kesavan)
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Mapreduce-trunk #31 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/31/)
      . Fix ant releaseaudit target to run on specific directories. (Contributed by Giridharan Kesavan)

      Show
      Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #31 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/31/ ) . Fix ant releaseaudit target to run on specific directories. (Contributed by Giridharan Kesavan)

        People

        • Assignee:
          Giridharan Kesavan
          Reporter:
          Giridharan Kesavan
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development