Hadoop Common
  1. Hadoop Common
  2. HADOOP-6150

Need to be able to instantiate a comparator instance from a comparator string without creating a TFile.Reader object

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.20.0, 0.21.0
    • Fix Version/s: 0.20.0, 0.21.0
    • Component/s: io
    • Labels:
      None

      Description

      Occasionally, we want have the same instance of comparator object represented by the TFile comparator string. We should be able to do that without requiring to first open up a tfile that was previously written use the same comparator.

      1. HADOOP-6150-0721.patch
        1 kB
        Hong Tang
      2. HADOOP-6150-0723-for-20.patch
        1 kB
        Hong Tang

        Activity

        Hide
        Hong Tang added a comment -

        Trivial patch that exposes an internal API to public. No unit test needed.

        Show
        Hong Tang added a comment - Trivial patch that exposes an internal API to public. No unit test needed.
        Hide
        Hong Tang added a comment -

        Same patch for hadoop 0.20.

        Show
        Hong Tang added a comment - Same patch for hadoop 0.20.
        Hide
        Hong Tang added a comment -

        test-patch output for patch for hadoop trunk:

        [exec] -1 overall.
        [exec]
        [exec] +1 @author. The patch does not contain any @author tags.
        [exec]
        [exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
        [exec] Please justify why no new tests are needed for this patch.
        [exec] Also please list what manual steps were performed to verify this patch.
        [exec]
        [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
        [exec]
        [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
        [exec]
        [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
        [exec]
        [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.

        Show
        Hong Tang added a comment - test-patch output for patch for hadoop trunk: [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
        Hide
        Raghu Angadi added a comment -

        +1.

        Show
        Raghu Angadi added a comment - +1.
        Hide
        Hong Tang added a comment -

        test-patch output for patch for hadoop 20:

        [exec] -1 overall.
        [exec]
        [exec] +1 @author. The patch does not contain any @author tags.
        [exec]
        [exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
        [exec] Please justify why no tests are needed for this patch.
        [exec]
        [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
        [exec]
        [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
        [exec]
        [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
        [exec]
        [exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

        Show
        Hong Tang added a comment - test-patch output for patch for hadoop 20: [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no tests are needed for this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
        Hide
        Raghu Angadi added a comment -

        I just committed this. Thanks Hong.

        Show
        Raghu Angadi added a comment - I just committed this. Thanks Hong.

          People

          • Assignee:
            Hong Tang
            Reporter:
            Hong Tang
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development