Hadoop Common
  1. Hadoop Common
  2. HADOOP-6139

Incomplete help message is displayed for rm and rmr options.

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.20.1
    • Fix Version/s: 0.20.1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Tags:
      ygridqa

      Description

      If path/src is missing from rm or rmr option then help message is displayed for these options.

      On giving command "hadoop dfs -rm"
      help message displayed is "Usage: java FsShell [-rm <path>]"
      while it should be "Usage: java FsShell [-rm [-skipTrash] <path>]"

      Same issue is there with rmr option also.

      1. HADOOP-478-v20.patch
        1 kB
        Jakob Homan
      2. COMMON-478.patch
        1 kB
        Jakob Homan

        Issue Links

          Activity

          Suman Sehgal created issue -
          Robert Chansler made changes -
          Field Original Value New Value
          Assignee Jakob Homan [ jghoman ]
          Hide
          Jakob Homan added a comment -

          Attaching patches for trunk and 20 branch. This is essentially a documentation change. Tested manually.

          Show
          Jakob Homan added a comment - Attaching patches for trunk and 20 branch. This is essentially a documentation change. Tested manually.
          Jakob Homan made changes -
          Attachment COMMON-478.patch [ 12413064 ]
          Attachment HADOOP-478-v20.patch [ 12413065 ]
          Owen O'Malley made changes -
          Project Hadoop HDFS [ 12310942 ] Hadoop Common [ 12310240 ]
          Key HDFS-478 HADOOP-6139
          Affects Version/s 0.20.1 [ 12313866 ]
          Affects Version/s 0.20.1 [ 12314048 ]
          Component/s hdfs client [ 12312928 ]
          Hide
          Jakob Homan added a comment -

          I had the issue moved to Common rather than HDFS since the affected file is FsShell.java, within the Common subproject.

          Show
          Jakob Homan added a comment - I had the issue moved to Common rather than HDFS since the affected file is FsShell.java, within the Common subproject.
          Hide
          Jakob Homan added a comment -

          submitting patch.

          Show
          Jakob Homan added a comment - submitting patch.
          Jakob Homan made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Jakob Homan added a comment -

          Ran unit tests locally. Passes all common unit tests.

          Show
          Jakob Homan added a comment - Ran unit tests locally. Passes all common unit tests.
          Hide
          Jakob Homan added a comment -

          test-patch:

               [exec] -1 overall.  
               [exec] 
               [exec]     +1 @author.  The patch does not contain any @author tags.
               [exec] 
               [exec]     -1 tests included.  The patch doesn't appear to include any new or modified tests.
               [exec]                         Please justify why no new tests are needed for this patch.
               [exec]                         Also please list what manual steps were performed to verify this patch.
               [exec] 
               [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
               [exec] 
               [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
               [exec] 
               [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
               [exec] 
               [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.

          No unit tests because is documentation change. Manual step as documented in jira description.

          Show
          Jakob Homan added a comment - test-patch: [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. No unit tests because is documentation change. Manual step as documented in jira description.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12413065/HADOOP-478-v20.patch
          against trunk revision 792812.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 patch. The patch command could not apply the patch.

          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/563/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12413065/HADOOP-478-v20.patch against trunk revision 792812. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/563/console This message is automatically generated.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          +1 patch looks good.

          Show
          Tsz Wo Nicholas Sze added a comment - +1 patch looks good.
          Tsz Wo Nicholas Sze made changes -
          Hadoop Flags [Reviewed]
          Hide
          Jakob Homan added a comment -

          Hudson tried to apply v20 patch, which is why I ran test-patch manually. Both pathces apply fine. Patch is ready to be committed.

          Show
          Jakob Homan added a comment - Hudson tried to apply v20 patch, which is why I ran test-patch manually. Both pathces apply fine. Patch is ready to be committed.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          I have committed this. Thanks, Jakob!

          Show
          Tsz Wo Nicholas Sze added a comment - I have committed this. Thanks, Jakob!
          Tsz Wo Nicholas Sze made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Fix Version/s 0.20.1 [ 12313866 ]
          Fix Version/s 0.21.0 [ 12313563 ]
          Resolution Fixed [ 1 ]
          Tsz Wo Nicholas Sze made changes -
          Link This issue is related to HDFS-489 [ HDFS-489 ]
          Tom White made changes -
          Fix Version/s 0.21.0 [ 12313563 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          17h 13m 1 Jakob Homan 09/Jul/09 23:57
          Patch Available Patch Available Resolved Resolved
          20h 32m 1 Tsz Wo Nicholas Sze 10/Jul/09 20:29

            People

            • Assignee:
              Jakob Homan
              Reporter:
              Suman Sehgal
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development