Details

    • Type: Test Test
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The wording should be changed when Hudson -1 a patch for no unit test updates. New wording to be be added in comments.

        Activity

        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12411136/HADOOP-5952.patch
        against trunk revision 786278.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/538/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/538/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/538/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/538/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12411136/HADOOP-5952.patch against trunk revision 786278. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/538/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/538/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/538/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/538/console This message is automatically generated.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #6 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/6/)
        . Change "-1 tests included" wording in test-patch.sh. Contributed by Gary Murry

        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #6 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/6/ ) . Change "-1 tests included" wording in test-patch.sh. Contributed by Gary Murry
        Hide
        Tsz Wo Nicholas Sze added a comment -

        I have committed this. Thanks, Gary!

        Show
        Tsz Wo Nicholas Sze added a comment - I have committed this. Thanks, Gary!
        Hide
        Tsz Wo Nicholas Sze added a comment -

        +1 new patch looks good.

        Show
        Tsz Wo Nicholas Sze added a comment - +1 new patch looks good.
        Hide
        gary murry added a comment -

        Results from test-patch

        [exec] +1 overall.
        [exec]
        [exec] +1 @author. The patch does not contain any @author tags.
        [exec]
        [exec] +1 tests included. The patch appears to include 3 new or modified tests.
        [exec]
        [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
        [exec]
        [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
        [exec]
        [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
        [exec]
        [exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
        [exec]
        [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.

        Note: not really +1 on tests included. But this does not need new tests since it is a minor chnge int he wording of test-patch.sh.

        Show
        gary murry added a comment - Results from test-patch [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. Note: not really +1 on tests included. But this does not need new tests since it is a minor chnge int he wording of test-patch.sh.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        > ... Please justify why no tests are needed for this patch...

        How about change it to "... Please justify why no new tests are needed for this patch..."?

        In some cases, a patch may fix problems with existing failing unit tests, or it is a performance improvement (so the correctness is tested by the existing tests).

        Show
        Tsz Wo Nicholas Sze added a comment - > ... Please justify why no tests are needed for this patch... How about change it to "... Please justify why no new tests are needed for this patch..."? In some cases, a patch may fix problems with existing failing unit tests, or it is a performance improvement (so the correctness is tested by the existing tests).
        Hide
        gary murry added a comment -

        The current wording is "-1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch." The new wording I would propose is "-1 tests include. The patch doesn't appear to include any new or modified test. Please justify why no tests are needed for this patch. Also please list what manual steps were performed to verify this patch." The wording was sent to core-dev@hadoop.apache.org with the only response being a +1 from Nigel.

        Show
        gary murry added a comment - The current wording is "-1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch." The new wording I would propose is "-1 tests include. The patch doesn't appear to include any new or modified test. Please justify why no tests are needed for this patch. Also please list what manual steps were performed to verify this patch." The wording was sent to core-dev@hadoop.apache.org with the only response being a +1 from Nigel.

          People

          • Assignee:
            gary murry
            Reporter:
            gary murry
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development