Hadoop Common
  1. Hadoop Common
  2. HADOOP-5951

StorageInfo needs Apache license header.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.19.0, 0.19.1, 0.20.0
    • Fix Version/s: 0.19.2, 0.20.1, 0.21.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The license headers are missing in this two files as reported by Flavio in HADOOP-5188.

      1. 5951.patch
        1 kB
        Suresh Srinivas

        Activity

        Hide
        Suresh Srinivas added a comment -

        Not adding unit tests as the change just adds apache banner to the file. Not running unit tests as there is no code change. Here is the test-patch result:
        [exec] -1 overall.
        [exec]
        [exec] +1 @author. The patch does not contain any @author tags.
        [exec]
        [exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
        [exec] Please justify why no tests are needed for this patch.
        [exec]
        [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
        [exec]
        [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
        [exec]
        [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
        [exec]
        [exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
        [exec]
        [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.

        Show
        Suresh Srinivas added a comment - Not adding unit tests as the change just adds apache banner to the file. Not running unit tests as there is no code change. Here is the test-patch result: [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no tests are needed for this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        +1

        Show
        Tsz Wo Nicholas Sze added a comment - +1
        Hide
        Tsz Wo Nicholas Sze added a comment -

        I have committed this (without submitting this to hudson) to 0.19 and above. Thanks, Suresh!

        Show
        Tsz Wo Nicholas Sze added a comment - I have committed this (without submitting this to hudson) to 0.19 and above. Thanks, Suresh!

          People

          • Assignee:
            Suresh Srinivas
            Reporter:
            Suresh Srinivas
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development