Hadoop Common
  1. Hadoop Common
  2. HADOOP-5948

Modify TestJavaSerialization to use LocalJobRunner instead of MiniMR/DFS cluster

    Details

    • Type: Test Test
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      TestJavaSerialization currently uses MiniMR/DFS cluster. This test can be done with local job runner also. This reduces the run time of the test from 61 seconds to 6 seconds.

      1. hadoop-5948.patch
        5 kB
        Jothi Padmanabhan

        Activity

        Hide
        Jothi Padmanabhan added a comment -

        Patch that changes the test not to use MiniMR

        Show
        Jothi Padmanabhan added a comment - Patch that changes the test not to use MiniMR
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12409543/hadoop-5948.patch
        against trunk revision 780567.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/445/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/445/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/445/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/445/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12409543/hadoop-5948.patch against trunk revision 780567. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/445/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/445/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/445/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/445/console This message is automatically generated.
        Hide
        Philip Zeyliger added a comment -

        +1 on making tests faster.

        private static String TEST_ROOT_DIR =
        new File(System.getProperty("test.build.data", "/tmp")).toURI()
        .toString().replace(' ', '+');

        Definitely off-topic, but I've seen this line, in many different incantations, throughout the code base. Is this something that could be added to UtilsForTest.java once and for all? Do you know why the string replacement is necessary?

        Show
        Philip Zeyliger added a comment - +1 on making tests faster. private static String TEST_ROOT_DIR = new File(System.getProperty("test.build.data", "/tmp")).toURI() .toString().replace(' ', '+'); Definitely off-topic, but I've seen this line, in many different incantations, throughout the code base. Is this something that could be added to UtilsForTest.java once and for all? Do you know why the string replacement is necessary?
        Hide
        Jothi Padmanabhan added a comment -

        Definitely off-topic, but I've seen this line, in many different incantations, throughout the code base. Is this something that could be added to UtilsForTest.java once and for all? Do you know why the string replacement is necessary?

        I do not think the string replacement is necessary. My guess is that this must have been added by somebody who had spaces in their test.build.data and has ever since found its way into all other test cases. I could be wrong though!

        Show
        Jothi Padmanabhan added a comment - Definitely off-topic, but I've seen this line, in many different incantations, throughout the code base. Is this something that could be added to UtilsForTest.java once and for all? Do you know why the string replacement is necessary? I do not think the string replacement is necessary. My guess is that this must have been added by somebody who had spaces in their test.build.data and has ever since found its way into all other test cases. I could be wrong though!
        Hide
        Devaraj Das added a comment -

        I just committed this. Thanks, Jothi!

        Show
        Devaraj Das added a comment - I just committed this. Thanks, Jothi!
        Hide
        Hudson added a comment -
        Show
        Hudson added a comment - Integrated in Hadoop-trunk #863 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/863/ )

          People

          • Assignee:
            Jothi Padmanabhan
            Reporter:
            Jothi Padmanabhan
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development