Hadoop Common
  1. Hadoop Common
  2. HADOOP-5944

BlockManager needs Apache license header.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.21.0
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The license headers are missing in this two files as reported by Flavio in HADOOP-5188.

      1. 5944.patch
        2 kB
        Suresh Srinivas
      2. 5944.patch
        1 kB
        Suresh Srinivas

        Activity

        Konstantin Shvachko created issue -
        Hide
        Konstantin Shvachko added a comment -

        This should be fixed separately and promoted to earlier versions.

        Show
        Konstantin Shvachko added a comment - This should be fixed separately and promoted to earlier versions.
        Suresh Srinivas made changes -
        Field Original Value New Value
        Assignee Suresh Srinivas [ sureshms ]
        Hide
        Suresh Srinivas added a comment -

        Storage already has Apache license header.

        Show
        Suresh Srinivas added a comment - Storage already has Apache license header.
        Hide
        Konstantin Shvachko added a comment -

        Sorry, I meant StorageInfo not Storage. Changing the summary now.

        Show
        Konstantin Shvachko added a comment - Sorry, I meant StorageInfo not Storage. Changing the summary now.
        Konstantin Shvachko made changes -
        Summary BlockManager and Storage need the Apache license header. BlockManager and StorageInfo need the Apache license header.
        Hide
        Suresh Srinivas added a comment -

        Since this is just adding header to the file, I ensured the code compiles. Not planning to run test-patch or unit tests to save time.

        Show
        Suresh Srinivas added a comment - Since this is just adding header to the file, I ensured the code compiles. Not planning to run test-patch or unit tests to save time.
        Suresh Srinivas made changes -
        Attachment 5944.patch [ 12409599 ]
        Hide
        Tsz Wo Nicholas Sze added a comment -

        +1

        Show
        Tsz Wo Nicholas Sze added a comment - +1
        Tsz Wo Nicholas Sze made changes -
        Hadoop Flags [Reviewed]
        Issue Type Improvement [ 4 ] Bug [ 1 ]
        Component/s dfs [ 12310710 ]
        Hide
        Tsz Wo Nicholas Sze added a comment -

        BlockManager was added in 0.21 (HADOOP-5015) but StorageInfo was added in 0.19 (HADOOP-2885). It may be hard to fix them together in a single jira.

        Show
        Tsz Wo Nicholas Sze added a comment - BlockManager was added in 0.21 ( HADOOP-5015 ) but StorageInfo was added in 0.19 ( HADOOP-2885 ). It may be hard to fix them together in a single jira.
        Hide
        Suresh Srinivas added a comment -

        New patch that adds the banner for BlockManager only. Here is the test-patch result:
        [exec] -1 overall.
        [exec]
        [exec] +1 @author. The patch does not contain any @author tags.
        [exec]
        [exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
        [exec] Please justify why no tests are needed for this patch.
        [exec]
        [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
        [exec]
        [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
        [exec]
        [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
        [exec]
        [exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
        [exec]
        [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.

        Show
        Suresh Srinivas added a comment - New patch that adds the banner for BlockManager only. Here is the test-patch result: [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no tests are needed for this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
        Suresh Srinivas made changes -
        Attachment 5944.patch [ 12409603 ]
        Suresh Srinivas made changes -
        Summary BlockManager and StorageInfo need the Apache license header. BlockManager need the Apache license header.
        Suresh Srinivas made changes -
        Summary BlockManager need the Apache license header. BlockManager needs Apache license header.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        StorageInfo will be fixed in HADOOP-5951.

        Show
        Tsz Wo Nicholas Sze added a comment - StorageInfo will be fixed in HADOOP-5951 .
        Tsz Wo Nicholas Sze made changes -
        Fix Version/s 0.21.0 [ 12313563 ]
        Fix Version/s 0.20.0 [ 12313438 ]
        Affects Version/s 0.21.0 [ 12313563 ]
        Affects Version/s 0.20.0 [ 12313438 ]
        Hide
        Tsz Wo Nicholas Sze added a comment -

        I have committed this (without submitting this to hudson). Thanks, Suresh!

        Show
        Tsz Wo Nicholas Sze added a comment - I have committed this (without submitting this to hudson). Thanks, Suresh!
        Tsz Wo Nicholas Sze made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -
        Show
        Hudson added a comment - Integrated in Hadoop-trunk #863 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/863/ )
        Owen O'Malley made changes -
        Component/s dfs [ 12310710 ]
        Tom White made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        2d 20h 15m 1 Tsz Wo Nicholas Sze 01/Jun/09 22:31
        Resolved Resolved Closed Closed
        448d 23h 6m 1 Tom White 24/Aug/10 21:38

          People

          • Assignee:
            Suresh Srinivas
            Reporter:
            Konstantin Shvachko
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development