Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Fix a few javac warnings under hdfs.

      I will list the files affected in jira i the following comment.

      1. HADOOP-5838.patch
        14 kB
        Raghu Angadi
      2. HADOOP-5838.patch
        14 kB
        Raghu Angadi

        Activity

        Hide
        Raghu Angadi added a comment -

        I just committed this.

        Show
        Raghu Angadi added a comment - I just committed this.
        Hide
        Raghu Angadi added a comment -

        ant test-patch :

             [exec]
             [exec] +1 overall.
             [exec]
             [exec]     +1 @author.  The patch does not contain any @author tags.
             [exec]
             [exec]     +1 tests included.  The patch appears to include 3 new or modified tests.
             [exec]
             [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
             [exec]
             [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
             [exec]
             [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
             [exec]
             [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
             [exec]
             [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
             [exec]
         
        Show
        Raghu Angadi added a comment - ant test-patch : [exec] [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec]
        Hide
        Raghu Angadi added a comment -

        Thanks Jakob. Updated patch has the suggested changes. Both are good changes.

        Show
        Raghu Angadi added a comment - Thanks Jakob. Updated patch has the suggested changes. Both are good changes.
        Hide
        Jakob Homan added a comment -

        Looks good. On line 104, can we get rid of the assert statement and just use the newly thrown exception?
        Amazingly tiny nit: DeprecatedUTF8 has a couple misspellings in comment (in stead => instead, SupressWarning => SuppressWarning).

        Other than that, +1.

        Show
        Jakob Homan added a comment - Looks good. On line 104, can we get rid of the assert statement and just use the newly thrown exception? Amazingly tiny nit: DeprecatedUTF8 has a couple misspellings in comment (in stead => instead, SupressWarning => SuppressWarning). Other than that, +1.
        Hide
        Jakob Homan added a comment -

        Nice. I'll review it shortly.

        Show
        Jakob Homan added a comment - Nice. I'll review it shortly.
        Hide
        Raghu Angadi added a comment -

        File fixed :

        • protocol/DatanodeID.java
        • protocol/NamespaceInfo.java
        • namenode/FSImage.java
        • namenode/DatanodeDescriptor.java
        • namenode/TransferFsImage.java
        • DistributedFileSystem.java
        • protocol/AlreadyBeingCreatedException.java
        • balancer/Balancer.java
        • protocol/NamespaceInfo.java
        • common/Storage.java
        • namenode/TestCheckpoint.java
        • DeprecatedUTF8.java
        • DFSUtil.java

        Most of the changes are trivial. Notable ones are :

        • Moved ErrorSimulator from deprecated SecondaryNamenode }}to {{DFSUtil
        • Added two wrappers in DeprecatedUTF8.java for the most commonly used methods. This is not required for javac, but ecplipse is more happier with them.
        Show
        Raghu Angadi added a comment - File fixed : protocol/DatanodeID.java protocol/NamespaceInfo.java namenode/FSImage.java namenode/DatanodeDescriptor.java namenode/TransferFsImage.java DistributedFileSystem.java protocol/AlreadyBeingCreatedException.java balancer/Balancer.java protocol/NamespaceInfo.java common/Storage.java namenode/TestCheckpoint.java DeprecatedUTF8.java DFSUtil.java Most of the changes are trivial. Notable ones are : Moved ErrorSimulator from deprecated SecondaryNamenode }}to {{DFSUtil Added two wrappers in DeprecatedUTF8.java for the most commonly used methods. This is not required for javac, but ecplipse is more happier with them.

          People

          • Assignee:
            Raghu Angadi
            Reporter:
            Raghu Angadi
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development