Hadoop Common
  1. Hadoop Common
  2. HADOOP-5824

remove OP_READ_METADATA functionality from Datanode

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Operation OP_READ_METADATA exists on the datanode streaming interface. But it is not used by any client code and is currently not protected by access token. Should it be removed?

      1. HADOOP-5824-0_20.1.patch
        4 kB
        Jitendra Nath Pandey
      2. 5824-2.patch
        4 kB
        Kan Zhang
      3. 5824-1.patch
        4 kB
        Kan Zhang
      4. 5824-0.patch
        3 kB
        Kan Zhang

        Issue Links

          Activity

          Kan Zhang created issue -
          Kan Zhang made changes -
          Field Original Value New Value
          Link This issue relates to HADOOP-4359 [ HADOOP-4359 ]
          Kan Zhang made changes -
          Attachment 5824-0.patch [ 12408052 ]
          Kan Zhang made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Raghu Angadi added a comment -

          +1 for removing it if it is not used.

          Show
          Raghu Angadi added a comment - +1 for removing it if it is not used.
          Kan Zhang made changes -
          Component/s dfs [ 12310710 ]
          Hide
          Tsz Wo Nicholas Sze added a comment -

          I like this too. Should we also remove OP_READ_METADATA from DataTransferProtocol?

          Show
          Tsz Wo Nicholas Sze added a comment - I like this too. Should we also remove OP_READ_METADATA from DataTransferProtocol?
          Kan Zhang made changes -
          Attachment 5824-1.patch [ 12408066 ]
          Hide
          Kan Zhang added a comment -

          > Should we also remove OP_READ_METADATA from DataTransferProtocol?
          Yes, I attached a new patch to that effect. thanks.

          Show
          Kan Zhang added a comment - > Should we also remove OP_READ_METADATA from DataTransferProtocol? Yes, I attached a new patch to that effect. thanks.
          Kan Zhang made changes -
          Attachment 5824-2.patch [ 12408086 ]
          Hide
          Kan Zhang added a comment -

          > Should we also remove OP_READ_METADATA from DataTransferProtocol?
          Added a new patch that deprecates the variable for now.

          Show
          Kan Zhang added a comment - > Should we also remove OP_READ_METADATA from DataTransferProtocol? Added a new patch that deprecates the variable for now.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          +1 patch looks good.

          Show
          Tsz Wo Nicholas Sze added a comment - +1 patch looks good.
          Tsz Wo Nicholas Sze made changes -
          Hadoop Flags [Reviewed]
          Assignee Kan Zhang [ kzhang ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12408086/5824-2.patch
          against trunk revision 774625.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no tests are needed for this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          -1 contrib tests. The patch failed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/337/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/337/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/337/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/337/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12408086/5824-2.patch against trunk revision 774625. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/337/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/337/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/337/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/337/console This message is automatically generated.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          The failed tests are not related.

          I have committed this. Thanks, Kan!

          Show
          Tsz Wo Nicholas Sze added a comment - The failed tests are not related. I have committed this. Thanks, Kan!
          Tsz Wo Nicholas Sze made changes -
          Resolution Fixed [ 1 ]
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Fix Version/s 0.21.0 [ 12313563 ]
          Owen O'Malley made changes -
          Component/s dfs [ 12310710 ]
          Hide
          Jitendra Nath Pandey added a comment -

          Patch for hadoop-20.

          Show
          Jitendra Nath Pandey added a comment - Patch for hadoop-20.
          Jitendra Nath Pandey made changes -
          Attachment HADOOP-5824-0_20.1.patch [ 12428759 ]
          Tom White made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Harsh J made changes -
          Link This issue is duplicated by HDFS-114 [ HDFS-114 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          12m 41s 1 Kan Zhang 13/May/09 23:06
          Patch Available Patch Available Resolved Resolved
          20h 6m 1 Tsz Wo Nicholas Sze 14/May/09 19:13
          Resolved Resolved Closed Closed
          467d 2h 24m 1 Tom White 24/Aug/10 21:37

            People

            • Assignee:
              Kan Zhang
              Reporter:
              Kan Zhang
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development