Hadoop Common
  1. Hadoop Common
  2. HADOOP-5818

Revert the renaming from checkSuperuserPrivilege to checkAccess by HADOOP-5643

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      HADOOP-5643 renamed FSNamesystem.checkSuperuserPrivilege to checkAccess. However, "checkAccess" is confusing in FSNamesystem since there are other methods, checkPathAccess(..), checkParentAccess(..) and checkAncestorAccess(..) which have different meanings.

      1. 5818for0.20.patch
        4 kB
        Robert Chansler
      2. HADOOP-5818-v1.0.patch
        3 kB
        Amar Kamat

        Issue Links

          Activity

          Hide
          Amar Kamat added a comment -

          Straightforward fix.

          Show
          Amar Kamat added a comment - Straightforward fix.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          +1 patch looks good.

          Show
          Tsz Wo Nicholas Sze added a comment - +1 patch looks good.
          Hide
          Tsz Wo Nicholas Sze added a comment -
               [exec] -1 overall.
               [exec]
               [exec]     +1 @author.  The patch does not contain any @author tags.
               [exec]
               [exec]     -1 tests included.  The patch doesn't appear to include any new or modified tests.
               [exec]                         Please justify why no tests are needed for this patch.
               [exec]
               [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
               [exec]
               [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
               [exec]
               [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
               [exec]
               [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
               [exec]
               [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
          

          Since this patch is reverting a renaming of a private method, I will commit it without submitting to Hudson.

          Show
          Tsz Wo Nicholas Sze added a comment - [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no tests are needed for this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. Since this patch is reverting a renaming of a private method, I will commit it without submitting to Hudson.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          I have committed this. Thanks, Amar!

          Show
          Tsz Wo Nicholas Sze added a comment - I have committed this. Thanks, Amar!
          Hide
          Robert Chansler added a comment -

          Example for 0.20 not to be committed.

          Show
          Robert Chansler added a comment - Example for 0.20 not to be committed.

            People

            • Assignee:
              Amar Kamat
              Reporter:
              Tsz Wo Nicholas Sze
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development