Hadoop Common
  1. Hadoop Common
  2. HADOOP-5718

Capacity Scheduler should not check for presence of default queue while starting up.

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.20.1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Remove the check for default queue while capacity scheduler initializes.

      1. HADOOP-5718-1.patch
        3 kB
        Sreekanth Ramakrishnan
      2. HADOOP-5718-2.patch
        4 kB
        Sreekanth Ramakrishnan
      3. HADOOP-5718-20.patch
        4 kB
        Sreekanth Ramakrishnan

        Activity

        Hide
        Sreekanth Ramakrishnan added a comment -

        Currently capacity scheduler checks for presence of default queue while starting up, ideally scheduler should not rely on any specific queue to be configured.

        Show
        Sreekanth Ramakrishnan added a comment - Currently capacity scheduler checks for presence of default queue while starting up, ideally scheduler should not rely on any specific queue to be configured.
        Hide
        Sreekanth Ramakrishnan added a comment -

        A straight forward patch. Attaching the patch removing the check from CapacityScheduler and added a new test case.

        Show
        Sreekanth Ramakrishnan added a comment - A straight forward patch. Attaching the patch removing the check from CapacityScheduler and added a new test case.
        Hide
        Hemanth Yamijala added a comment -
        • The variable 'DEFAULT_QUEUE_NAME' can be removed.
        • Maybe unrelated to this patch, but the new raiseStatusChangeEvents should be used in atleast one more test case, testSchedulingInformation. Can you please check this, and other usages of the old raiseStatusChangeEvents method ?

        Otherwise, the code changes are fine.

        Show
        Hemanth Yamijala added a comment - The variable 'DEFAULT_QUEUE_NAME' can be removed. Maybe unrelated to this patch, but the new raiseStatusChangeEvents should be used in atleast one more test case, testSchedulingInformation. Can you please check this, and other usages of the old raiseStatusChangeEvents method ? Otherwise, the code changes are fine.
        Hide
        Sreekanth Ramakrishnan added a comment -

        Attaching patch incorporating Hemanth's comment:

        • Add raiseStatusChangeEvent(JobQueueManager, QueueName) to testSchedulingInfo()

        No other test case needs it because places where raiseStatusChangeEvent() is being used is with single default queue.

        Show
        Sreekanth Ramakrishnan added a comment - Attaching patch incorporating Hemanth's comment: Add raiseStatusChangeEvent(JobQueueManager, QueueName) to testSchedulingInfo() No other test case needs it because places where raiseStatusChangeEvent() is being used is with single default queue.
        Hide
        Sreekanth Ramakrishnan added a comment -

        Running thro hudson.

        Show
        Sreekanth Ramakrishnan added a comment - Running thro hudson.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12406348/HADOOP-5718-2.patch
        against trunk revision 770321.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/266/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/266/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/266/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/266/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12406348/HADOOP-5718-2.patch against trunk revision 770321. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/266/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/266/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/266/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/266/console This message is automatically generated.
        Hide
        Sreekanth Ramakrishnan added a comment -

        Attaching patch for branch 20.

        Show
        Sreekanth Ramakrishnan added a comment - Attaching patch for branch 20.
        Hide
        Hemanth Yamijala added a comment -

        The earlier patch for trunk did not apply to trunk because of commit of HADOOP-5726. However, the patch for branch 0.20 is applying cleanly. I ran ant test-patch on this to make sure it still approves. Capacity scheduler tests also run fine. So, I will commit this patch to both 0.20 and trunk.

        Show
        Hemanth Yamijala added a comment - The earlier patch for trunk did not apply to trunk because of commit of HADOOP-5726 . However, the patch for branch 0.20 is applying cleanly. I ran ant test-patch on this to make sure it still approves. Capacity scheduler tests also run fine. So, I will commit this patch to both 0.20 and trunk.
        Hide
        Hemanth Yamijala added a comment -

        I committed this to trunk and branch 0.20. Thanks, Sreekanth !

        Show
        Hemanth Yamijala added a comment - I committed this to trunk and branch 0.20. Thanks, Sreekanth !
        Hide
        Hudson added a comment -

        Integrated in Hadoop-trunk #827 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/827/)
        . Remove the check for the default queue in capacity scheduler. Contributed by Sreekanth Ramakrishnan.

        Show
        Hudson added a comment - Integrated in Hadoop-trunk #827 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/827/ ) . Remove the check for the default queue in capacity scheduler. Contributed by Sreekanth Ramakrishnan.

          People

          • Assignee:
            Sreekanth Ramakrishnan
            Reporter:
            Sreekanth Ramakrishnan
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development