Hadoop Common
  1. Hadoop Common
  2. HADOOP-5647

TestJobHistory fails if /tmp/_logs is not writable to. Testcase should not depend on /tmp

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.20.203.0, 0.23.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Removed dependency of testcase on /tmp and made it to use test.build.data directory instead.

      Description

      TestJobHistory sets /tmp as hadoop.job.history.user.location to check if the history file is created in that directory or not. If /tmp/_logs is already created by some other user, this test will fail because of not having write permission.

      1. HADOOP-5647.patch
        1 kB
        Ravi Gummadi
      2. yhadoop20-5647.patch
        2 kB
        Ravi Gummadi

        Activity

        Hide
        Ravi Gummadi added a comment -

        Attaching patch removing dependency of testcase on /tmp.

        Show
        Ravi Gummadi added a comment - Attaching patch removing dependency of testcase on /tmp.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        +1

        Show
        Tsz Wo Nicholas Sze added a comment - +1
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12405040/HADOOP-5647.patch
        against trunk revision 765062.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/197/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/197/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/197/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/197/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12405040/HADOOP-5647.patch against trunk revision 765062. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/197/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/197/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/197/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/197/console This message is automatically generated.
        Hide
        Ravi Gummadi added a comment -

        Failures in unit tests shown above are nothing to do with this patch.

        Show
        Ravi Gummadi added a comment - Failures in unit tests shown above are nothing to do with this patch.
        Hide
        Sharad Agarwal added a comment -

        I just committed this. Thanks Ravi!

        Show
        Sharad Agarwal added a comment - I just committed this. Thanks Ravi!
        Hide
        Hudson added a comment -
        Show
        Hudson added a comment - Integrated in Hadoop-trunk #811 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/811/ )
        Hide
        Robert Chansler added a comment -

        Editorial pass over all release notes prior to publication of 0.21.

        Show
        Robert Chansler added a comment - Editorial pass over all release notes prior to publication of 0.21.
        Hide
        Ravi Gummadi added a comment -

        Attaching patch for yahoo hadoop 0.20 branch.

        Show
        Ravi Gummadi added a comment - Attaching patch for yahoo hadoop 0.20 branch.
        Hide
        Sharad Agarwal added a comment -

        +1 on Yahoo 0.20 patch.

        Show
        Sharad Agarwal added a comment - +1 on Yahoo 0.20 patch.
        Hide
        Todd Lipcon added a comment -

        I'd like to propose this gets committed to branch-20 - it's only a change to test code, and the branch-20 tests sporadically fail due to it.

        Show
        Todd Lipcon added a comment - I'd like to propose this gets committed to branch-20 - it's only a change to test code, and the branch-20 tests sporadically fail due to it.
        Hide
        Konstantin Boudnik added a comment -

        +1 on adding this to .20 branch

        Show
        Konstantin Boudnik added a comment - +1 on adding this to .20 branch
        Hide
        Owen O'Malley added a comment -

        This was committed by Sharad.

        Show
        Owen O'Malley added a comment - This was committed by Sharad.
        Hide
        Owen O'Malley added a comment -

        Closing for 0.20.203.0

        Show
        Owen O'Malley added a comment - Closing for 0.20.203.0

          People

          • Assignee:
            Ravi Gummadi
            Reporter:
            Ravi Gummadi
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development