Hadoop Common
  1. Hadoop Common
  2. HADOOP-5557

Two minor problems in TestOverReplicatedBlocks

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.18.4, 0.19.2, 0.20.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      • There is no apache license header.
      • It uses a deprecated API, FSNamesystem.getFSNamesystem().
      1. 5557_20090323_0.18.patch
        1 kB
        Tsz Wo Nicholas Sze
      2. 5557_20090323_0.20.patch
        1 kB
        Tsz Wo Nicholas Sze
      3. 5557_20090323.patch
        2 kB
        Tsz Wo Nicholas Sze

        Activity

        Hide
        Tsz Wo Nicholas Sze added a comment -

        5557_20090323.patch: fixes both problems.

        Show
        Tsz Wo Nicholas Sze added a comment - 5557_20090323.patch: fixes both problems.
        Hide
        Hairong Kuang added a comment -

        +1

        Show
        Hairong Kuang added a comment - +1
        Hide
        Tsz Wo Nicholas Sze added a comment -
             [exec] +1 overall.  
             [exec] 
             [exec]     +1 @author.  The patch does not contain any @author tags.
             [exec] 
             [exec]     +1 tests included.  The patch appears to include 3 new or modified tests.
             [exec] 
             [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
             [exec] 
             [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
             [exec] 
             [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
             [exec] 
             [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
             [exec] 
             [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
        

        Ran TestOverReplicatedBlocks. It worked fine.

        Show
        Tsz Wo Nicholas Sze added a comment - [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. Ran TestOverReplicatedBlocks. It worked fine.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        5557_20090323_0.20.patch: for 0.20
        5557_20090323_0.18.patch: for 0.18

        Show
        Tsz Wo Nicholas Sze added a comment - 5557_20090323_0.20.patch: for 0.20 5557_20090323_0.18.patch: for 0.18
        Hide
        Tsz Wo Nicholas Sze added a comment -

        I have committed this to 0.18 and above.

        Show
        Tsz Wo Nicholas Sze added a comment - I have committed this to 0.18 and above.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-trunk #789 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/789/)
        . Fixes some minor problems in TestOverReplicatedBlocks. (szetszwo)

        Show
        Hudson added a comment - Integrated in Hadoop-trunk #789 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/789/ ) . Fixes some minor problems in TestOverReplicatedBlocks. (szetszwo)
        Hide
        Hudson added a comment -

        Integrated in Hadoop-trunk #790 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/790/)
        Move change log from 0.18.3 to 0.18.4.

        Show
        Hudson added a comment - Integrated in Hadoop-trunk #790 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/790/ ) Move change log from 0.18.3 to 0.18.4.

          People

          • Assignee:
            Tsz Wo Nicholas Sze
            Reporter:
            Tsz Wo Nicholas Sze
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development