Hadoop Common
  1. Hadoop Common
  2. HADOOP-554

hadoop dfs command line doesn't exit with status code on error

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0
    • Component/s: None
    • Labels:
      None

      Description

      In DFSClient, the code looks like:

      ---- >8 ----

      int exitCode = -1;
      ...
      try {
      if ("-put".equals(cmd) || "-copyFromLocal".equals(cmd))

      { copyFromLocal(new Path(argv[i++]), argv[i++]); ... exitCode = 0;; }

      catch (IOException e )

      { System.err.println( cmd.substring(1) + ": " + e.getLocalizedMessage() ); }

      finally

      { fs.close(); }

      return exitCode;

      ---- 8< ----

      Point 1: Few, if any of the functions called throw an exception. Instead they System.err.println and return.
      Point 2: exitCode, regardless if there is an exception, is always 0.

      At minimum, it would be best if SOME status code were returned, so that any scripts calling hadoop dfs would know to parse the output.

      At best, there'd be a well-documented table of exit codes so that parsing stderr wouldn't be required.

      1. errorcodes.patch
        2 kB
        dhruba borthakur

        Activity

          People

          • Assignee:
            dhruba borthakur
            Reporter:
            Marco Nicosia
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development